Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix the download icon on attachments #573

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Nov 25, 2016

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

}).then(function(svgText) {
const svg = new DOMParser().parseFromString(svgText, "image/svg+xml");
// Also note that we can't use fetch here because fetch doesn't support
// file URLs, which the download image will be if we're running from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course it doesn't.

@richvdh richvdh merged commit 1a41637 into develop Nov 29, 2016
@dbkr dbkr deleted the dbkr/electron_fix_download_icon branch December 14, 2016 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants