Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Improved forwarding UI #5999

Merged
merged 42 commits into from
Jun 8, 2021
Merged

Improved forwarding UI #5999

merged 42 commits into from
Jun 8, 2021

Commits on May 9, 2021

  1. Replace forwarding UI with dialog 

    Replaces the old forwarding UI with a dialog based on designs from
element-hq/element-web#14690.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 9, 2021
    Configuration menu
    Copy the full SHA
    b9b237f View commit details
    Browse the repository at this point in the history

  2. Test ForwardDialog 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 9, 2021
    Configuration menu
    Copy the full SHA
    74925b2 View commit details
    Browse the repository at this point in the history

  3. Remove old forwarding code 

    This has been replaced by ForwardDialog.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 9, 2021
    Configuration menu
    Copy the full SHA
    7fa8176 View commit details
    Browse the repository at this point in the history

  4. Use import instead of sdk.getComponent 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 9, 2021
    Configuration menu
    Copy the full SHA
    219c983 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Make ForwardDialog more readable 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    c96888c View commit details
    Browse the repository at this point in the history

  2. Fix ForwardDialog crashing when rendering reply 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    100efb1 View commit details
    Browse the repository at this point in the history

  3. Test that ForwardDialog can render replies 

    Previously ForwardDialog was not giving its EventTile message preview
the information it needed to render a ReplyThread. This was a bit tricky
to fix since we were pulling a fake event out of thin air, so this
ensures it doesn't regress.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    eb07f1f View commit details
    Browse the repository at this point in the history

  4. Find components by name rather than class in ForwardDialog test 

    It makes things shorter and more readable!

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    35cf0e1 View commit details
    Browse the repository at this point in the history

  5. Disable forward buttons for rooms without send permissions 

    …and add a tooltip to explain why they can't accept forwarded messages.
It was chosen to disable the buttons rather than hide the entries from
the list, since hiding them without explanation could cause confusion.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    09ba74a View commit details
    Browse the repository at this point in the history

  6. Test that forward buttons are disabled for rooms without permission 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    eb779cd View commit details
    Browse the repository at this point in the history

  7. Fix lints 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    5c10e1e View commit details
    Browse the repository at this point in the history

  8. Push ForwardDialog scrollbar into the gutter 

    …to give more space between it and the buttons.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    bfba2b0 View commit details
    Browse the repository at this point in the history

  9. Make rooms in ForwardDialog clickable 

    …so that you can jump to a room easily once you've forwarded a message
there.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    503301a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'develop' into improved-forwarding-ui

    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    c39d964 View commit details
    Browse the repository at this point in the history

  11. Hide unencrypted badge from ForwardDialog preview 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 10, 2021
    Configuration menu
    Copy the full SHA
    7efbd2d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2021

  1. Merge branch 'develop' into improved-forwarding-ui

    @robintown
    robintown committed May 16, 2021
    Configuration menu
    Copy the full SHA
    64e828d View commit details
    Browse the repository at this point in the history

  2. Decorate forward dialog room avatars 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 16, 2021
    Configuration menu
    Copy the full SHA
    e798b36 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Merge branch 'develop' into improved-forwarding-ui

    @robintown
    robintown committed May 19, 2021
    Configuration menu
    Copy the full SHA
    678b298 View commit details
    Browse the repository at this point in the history

  2. Ensure forward list room decorations are aligned 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 19, 2021
    Configuration menu
    Copy the full SHA
    83224dc View commit details
    Browse the repository at this point in the history

  3. Combine forward dialog room and DM lists 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 19, 2021
    Configuration menu
    Copy the full SHA
    6cb6c7f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Merge branch 'develop' into improved-forwarding-ui

    @robintown
    robintown committed May 21, 2021
    Configuration menu
    Copy the full SHA
    f34d61c View commit details
    Browse the repository at this point in the history

  2. Iterate on forward dialog design feedback 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 21, 2021
    Configuration menu
    Copy the full SHA
    7a04502 View commit details
    Browse the repository at this point in the history

  3. Adjust forward dialog copy 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 21, 2021
    Configuration menu
    Copy the full SHA
    cd460a2 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Merge branch 'develop' into improved-forwarding-ui

    @robintown
    robintown committed May 24, 2021
    Configuration menu
    Copy the full SHA
    88e0e9b View commit details
    Browse the repository at this point in the history

  2. Make myself the copyright holder for forward dialog code 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 24, 2021
    Configuration menu
    Copy the full SHA
    4009176 View commit details
    Browse the repository at this point in the history

  3. Use camelCase 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 24, 2021
    Configuration menu
    Copy the full SHA
    6ced61b View commit details
    Browse the repository at this point in the history

  4. Pass Matrix client around as matrixClient 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 24, 2021
    Configuration menu
    Copy the full SHA
    121ed5e View commit details
    Browse the repository at this point in the history

  5. Give forward dialog send buttons an accessible label 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed May 24, 2021
    Configuration menu
    Copy the full SHA
    5c7da97 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Merge branch 'develop' into improved-forwarding-ui

    @robintown
    robintown committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    5671452 View commit details
    Browse the repository at this point in the history

  2. Fix whitespace lints 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    b032422 View commit details
    Browse the repository at this point in the history

  3. Match forward dialog send failed indicator color with button 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    8efbdd0 View commit details
    Browse the repository at this point in the history

  4. Remove unused class 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    c781679 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Use settings hooks in forward dialog 

    ...to dynamically watch for layout changes.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4ef69fc View commit details
    Browse the repository at this point in the history

  2. Use a QueryMatcher for forward dialog filtering 

    This also allows us to filter by room aliases.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    59660df View commit details
    Browse the repository at this point in the history

  3. Fix forward dialog tests 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    992861a View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2021

  1. Merge branch 'develop' into improved-forwarding-ui

    @robintown
    robintown committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    a06306d View commit details
    Browse the repository at this point in the history

  2. Fix type check 

    As TypeScript points out, you can only set an id on HTML elements, not
arbitrary components.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    bbd5fab View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. Add my email to my copyright notices 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    e891d18 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Merge branch 'develop' into improved-forwarding-ui

    @robintown
    robintown committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    b978672 View commit details
    Browse the repository at this point in the history

  2. Remove mystery dot from forward dialog preview 

    It was a bullet point, since EventTiles now get created as li by default
:P

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    a8dab04 View commit details
    Browse the repository at this point in the history

  3. Fix whitespace nitpick 

    Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    b00ad63 View commit details
    Browse the repository at this point in the history

  4. Hide download links from forward dialog preview 

    since trying to interact with them is pointless.

Signed-off-by: Robin Townsend <robin@robin.town>
    @robintown
    robintown committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    372f24f View commit details
    Browse the repository at this point in the history