Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

TypeScript migration for auth components #6412

Merged
merged 18 commits into from
Jul 21, 2021
Merged

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Jul 20, 2021

No description provided.

@germain-gg germain-gg requested a review from a team July 20, 2021 06:57
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, it's possible and won't result in test failures

src/components/views/auth/AuthHeader.tsx Outdated Show resolved Hide resolved
src/components/views/auth/AuthPage.tsx Outdated Show resolved Hide resolved
src/components/views/auth/CountryDropdown.tsx Outdated Show resolved Hide resolved
src/components/views/auth/LanguageSelector.tsx Outdated Show resolved Hide resolved
src/components/views/auth/Welcome.tsx Outdated Show resolved Hide resolved
src/@types/global.d.ts Outdated Show resolved Hide resolved
src/components/views/auth/CountryDropdown.tsx Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member

t3chguy commented Jul 20, 2021

Also thanks @SimonBrandner for first round of review

@SimonBrandner
Copy link
Contributor

Also thanks @SimonBrandner for first round of review

I wouldn't really call it a review - I just couldn't help myself, sdk.getComponents are painful to look at 😄

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
@germain-gg germain-gg requested a review from t3chguy July 20, 2021 16:19
src/@types/global.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:

@germain-gg germain-gg merged commit ae60692 into develop Jul 21, 2021
@germain-gg germain-gg deleted the gsouqet/ts-migration-1 branch July 21, 2021 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants