Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update muting in calls to work with the js-sdk call upgrade changes #6547

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Aug 4, 2021

Type: task
Requires matrix-org/matrix-js-sdk#1827


This is not call upgrade support


Since design is busy with other stuff I've decided to land call upgrade support in the js-sdk without support in Element. Once this lands we can experiment with call upgrades in group calls and similar things


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://6146cf49d86da16b8d552342--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@robintown
Copy link
Member

Closes element-hq/element-web#12646?

@SimonBrandner
Copy link
Contributor Author

Closes vector-im/element-web#12646?

Yeah, I mainly wanted to put the thing on GH and I didn't bother doing that :D

@SimonBrandner SimonBrandner added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 4, 2021
@SimonBrandner SimonBrandner requested review from dbkr and removed request for dbkr August 5, 2021 10:41
@SimonBrandner SimonBrandner force-pushed the feature/call-upgrades branch 7 times, most recently from c106337 to cbb94af Compare September 2, 2021 05:38
@SimonBrandner SimonBrandner force-pushed the feature/call-upgrades branch 3 times, most recently from e18cf34 to 4ad830e Compare September 18, 2021 10:40
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner changed the title Support upgrading voice calls to video calls Update muting in calls to work with the js-sdk call upgrade changes Sep 18, 2021
@SimonBrandner SimonBrandner added T-Task Refactoring, enabling or disabling functionality, other engineering tasks and removed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Sep 18, 2021
@SimonBrandner SimonBrandner marked this pull request as ready for review September 18, 2021 10:46
@SimonBrandner SimonBrandner requested a review from a team as a code owner September 18, 2021 10:46
@turt2live turt2live merged commit 3a548d4 into matrix-org:develop Sep 21, 2021
@SimonBrandner SimonBrandner deleted the feature/call-upgrades branch September 21, 2021 15:19
@turt2live
Copy link
Member

(thank you for the reminder - I honestly thought I'd be smart enough to merge based on the js-sdk PR, but apparently not)

@SimonBrandner
Copy link
Contributor Author

(thank you for the reminder - I honestly thought I'd be smart enough to merge based on the js-sdk PR, but apparently not)

We need some automatic way to do this anyway

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants