Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make thread button always visible #6903

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Make thread button always visible #6903

merged 2 commits into from
Oct 11, 2021

Conversation

Palid
Copy link
Contributor

@Palid Palid commented Oct 4, 2021

Fix element-hq/element-web#18956


Here's what your changelog entry will look like:

✨ Features

Preview: https://6161dc6d31ee6c71401c7839--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@Palid Palid requested a review from a team as a code owner October 4, 2021 12:34
@Palid Palid added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 4, 2021
@Palid Palid enabled auto-merge (squash) October 4, 2021 12:34
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's almost there! 💯

Screen Shot 2021-10-04 at 14 03 33

I believe we should not have the "Thread" action in the bar when the tile is displayed within the thread view

Also, it looks like the CI is grunting at you

@Palid
Copy link
Contributor Author

Palid commented Oct 4, 2021

Why are warnings considered errors in CI? 🤬
fixing.

@Palid Palid force-pushed the palid/feature/185956 branch from 45be7fe to d2ef204 Compare October 4, 2021 13:09
@Palid Palid requested a review from germain-gg October 4, 2021 13:09
@Palid Palid disabled auto-merge October 9, 2021 18:12
@Palid Palid enabled auto-merge (squash) October 9, 2021 18:13
@Palid Palid requested a review from germain-gg October 9, 2021 18:13
@Palid Palid merged commit 414b20f into develop Oct 11, 2021
@Palid Palid deleted the palid/feature/185956 branch October 11, 2021 09:26
Palid pushed a commit that referenced this pull request Oct 12, 2021
* origin/develop: (27 commits)
  Fix room list skeleton ui for narrow room list
  Reset matrix-js-sdk back to develop branch
  Resetting package fields for development
  v3.32.1
  Prepare changelog for v3.32.1
  Upgrade matrix-js-sdk to 14.0.1
  Remove semicolon from notifications panel
  Resetting package fields for development
  v3.32.0
  Prepare changelog for v3.32.0
  Upgrade matrix-js-sdk to 14.0.0
  Hide Skeleton UI if you have Suggested Rooms
  Tweak skeleton UI height to be more reasonable
  Iterate invite your teammates to Space view
  Make thread button always visible (#6903)
  Prevent backdrop image from being selected
  v3.32.0-rc.2
  Prepare changelog for v3.32.0-rc.2
  Upgrade matrix-js-sdk to 14.0.0-rc.2
  Simplify and improve useRoomHierarchy hook
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create thread deleted state UI
2 participants