This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add threads ViewInRoom context button (#18955) #6947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Palid
added
the
T-Enhancement
auto-merge was automatically disabled
October 14, 2021 13:56
Pull request was converted to draft
Palid
force-pushed
the
palid/feature/18955
branch
from
5e2af3b to
b157200
Compare
germain-gg
suggested changes
Oct 14, 2021
There was a problem hiding this comment.
Code looks good to me 💯 🚀 !
One thing to change before it can go in production, after clicking on "View in room" the context menu remains open and focused
From a usability and accessility point of view, the context menu should auto close after clicking "View in room" and the focus should be transfered to the highlighted event (but I assume this should already be handled, probably worth double checking)
|
@gsouquet fixed! |
* origin/develop: (29 commits) Run i18n generation appease the linter Add spacing to Room settings - Notifications subsection Move error message closer to password field Name CryptographyPanel CSS classes consistent with style Break 'Cryptography' settings into a separate component Allow EventTile to be rendered with mock events Adding renderThreadInfo comment to explain data accessor Do more re-ordering to keep things working Add new thread message preview (#18958) (#6953) Remove repeated comment Merge duplicate CSS selectors Switch DevicesPanel to use table (for screen readers) Fix tooltip when downloading unencrypted file Listen to new thread to render info on timeline Reconcile threads root with its children before displaying it Fix incorrect logic to hide thread relations Remove auto-import Add 'm.thread' relation for replies to a threaded event Make threads use 'm.thread' relation ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#18955
Here's what your changelog entry will look like:
✨ Features
Preview: https://616d6357fe4d44c3c5475623--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.