Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Simple static location sharing #7135

Merged
merged 32 commits into from
Dec 6, 2021
Merged

Simple static location sharing #7135

merged 32 commits into from
Dec 6, 2021

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Nov 15, 2021 •
edited by github-actions bot
Loading

A quick and dirty implementation of plain old m.location msgtype location sharing via maplibre-gl, mixing in matrix-org/matrix-spec-proposals#3488 for forwards compatibility.

Requires element-hq/element-web#19754

Stuff remaining:

  • fix lint
  • fix types
  • render description
  • stop the UI prompting for streaming until MSC3489 streaming is hooked up.
  • fix tests

Stuff punted for future PRs:

  • add thumbnail fallbacks
  • let the user drop a pin in a specific location
  • render uncertainty circle

Here's what your changelog entry will look like:

✨ Features

  • Simple static location sharing (#7135).

Preview: https://61acb1cab46d1e0ed42b507a--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@ara4n ara4n requested a review from a team as a code owner November 15, 2021 02:17
@ara4n ara4n mentioned this pull request Nov 15, 2021
Merged
@turt2live turt2live marked this pull request as draft November 15, 2021 02:17
@turt2live turt2live removed the request for review from a team November 15, 2021 02:18
@ara4n ara4n mentioned this pull request Nov 15, 2021
Open
@ara4n ara4n changed the title WIP: static location sharing Simple static location sharing Nov 21, 2021
@ara4n ara4n added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Nov 21, 2021
@ara4n ara4n marked this pull request as ready for review November 21, 2021 20:19
@ara4n
Copy link
Member Author

ara4n commented Nov 21, 2021

Other than needing to figure out how to fix the tests by mocking maplibre correctly (maybe using https://github.com/mapbox/mapbox-gl-js-mock?) i think this is good to go.

@ara4n ara4n requested a review from a team November 21, 2021 20:20
@ara4n ara4n requested a review from a team November 22, 2021 20:51
@ara4n ara4n mentioned this pull request Nov 23, 2021
Merged
@SimonBrandner
Copy link
Contributor

Screenshot_20211123_074726

Is it expected for me to see an empty map?

andybalaam
andybalaam approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@t3chguy
Copy link
Member

t3chguy commented Nov 23, 2021

@SimonBrandner I'm guessing its due to missing API in config.json

t3chguy
t3chguy suggested changes Nov 23, 2021
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment •
edited by ara4n
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • Should not be enabled/error when the API is missing in config.json
  • Should handle API errors better than just showing no map.

@andybalaam
Copy link
Member

Confirming this worked for me on a local install with a config file containing a maptiler API key.

@ara4n
Copy link
Member Author

ara4n commented Dec 5, 2021

This now checks and warns for misconfigured tileserver nicely. PTAL; should be good to merge now.

@ara4n ara4n requested a review from a team December 5, 2021 12:42
t3chguy
t3chguy approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

res/css/views/location/_LocationPicker.scss Show resolved Hide resolved
@ara4n ara4n merged commit 1262021 into develop Dec 6, 2021
@ara4n ara4n deleted the matthew/location-share branch December 6, 2021 09:45
ara4n added a commit to element-hq/element-web that referenced this pull request Dec 6, 2021
@ara4n
Simple static location sharing (#19754)
9b780e0 
Adds static location share a la [MSC3488](matrix-org/matrix-spec-proposals#3488) behind a labs flag, supporting legacy `m.location` `msgtype` too.  Powered by matrix-org/matrix-react-sdk#7135.  Adds maplibre as a dependency.

To make this work, you have to add a valid `map_style_url` to your config.json.
BBaoVanC added a commit to boba-best/element.boba.best that referenced this pull request Dec 20, 2021
@BBaoVanC
Merge tag 'v1.9.8' into build
3875bbe 
* Include Vietnamese language ([\element-hq#20029](element-hq#20029)).
* Simple static location sharing ([\element-hq#19754](element-hq#19754)).
* Add support for the Indonesian language ([\element-hq#20032](element-hq#20032)). Fixes element-hq#20030. Contributed by @Linerly.
* Always unhide widgets on layout change (pinning a widget) ([\element-hq#7299](matrix-org/matrix-react-sdk#7299)).
* Update status message in the member list and user info panel when it is changed ([\element-hq#7338](matrix-org/matrix-react-sdk#7338)). Fixes element-hq#20127. Contributed by @SimonBrandner.
* Iterate space panel toggle collapse interaction ([\element-hq#7335](matrix-org/matrix-react-sdk#7335)). Fixes element-hq#20079.
* Spotlight search labs ([\element-hq#7116](matrix-org/matrix-react-sdk#7116)). Fixes element-hq#19530.
* Put room settings form elements in fieldsets ([\element-hq#7311](matrix-org/matrix-react-sdk#7311)).
* Add descriptions to ambiguous links for screen readers ([\element-hq#7310](matrix-org/matrix-react-sdk#7310)).
* Make tooltips keyboard accessible ([\#7281](matrix-org/matrix-react-sdk#7281)).
* Iterate room context menus for DMs ([\element-hq#7308](matrix-org/matrix-react-sdk#7308)). Fixes element-hq#19527.
* Update space panel expand mechanism ([\element-hq#7230](matrix-org/matrix-react-sdk#7230)). Fixes element-hq#17993.
* Add CSS variable to make the UI gaps consistent and fix the resize handle position ([\element-hq#7234](matrix-org/matrix-react-sdk#7234)). Fixes element-hq#19904 and element-hq#19938.
* Custom location sharing. ([\element-hq#7185](matrix-org/matrix-react-sdk#7185)).
* Simple static location sharing ([\element-hq#7135](matrix-org/matrix-react-sdk#7135)).
* Finish sending pending messages before leaving room ([\element-hq#7276](matrix-org/matrix-react-sdk#7276)). Fixes element-hq#4702.
* Dropdown follow wai-aria practices for expanding on arrow keys ([\element-hq#7277](matrix-org/matrix-react-sdk#7277)). Fixes element-hq#3687.
* Expose PL control for pinned events when lab enabled ([\element-hq#7278](matrix-org/matrix-react-sdk#7278)). Fixes element-hq#5396.
* In People & Favourites metaspaces always show all rooms ([\element-hq#7288](matrix-org/matrix-react-sdk#7288)). Fixes element-hq#20048.
* Don't allow calls when the connection the server has been lost ([\element-hq#7287](matrix-org/matrix-react-sdk#7287)). Fixes element-hq#2096. Contributed by @SimonBrandner.
* Analytics opt in for posthog ([\element-hq#6936](matrix-org/matrix-react-sdk#6936)).
* Don't inhibit current room notifications if user has Modal open ([\element-hq#7274](matrix-org/matrix-react-sdk#7274)). Fixes element-hq#1118.
* Remove the `Screen sharing is here!` dialog ([\#7266](matrix-org/matrix-react-sdk#7266)). Fixes element-hq#18824. Contributed by @SimonBrandner.
* Make composer buttons react to settings without having to change room ([\element-hq#7264](matrix-org/matrix-react-sdk#7264)). Fixes element-hq#20011.
* Decorate view keyboard shortcuts link as a link ([\element-hq#7260](matrix-org/matrix-react-sdk#7260)). Fixes element-hq#20007.
* Improve ease of focusing on Room list Search ([\element-hq#7255](matrix-org/matrix-react-sdk#7255)). Fixes matrix-org/element-web-rageshakes#7017.
* Autofocus device panel entry when renaming device ([\element-hq#7249](matrix-org/matrix-react-sdk#7249)). Fixes element-hq#19984.
* Update Space Panel scrollable region ([\element-hq#7245](matrix-org/matrix-react-sdk#7245)). Fixes element-hq#19978.
* Replace breadcrumbs with recently viewed menu ([\element-hq#7073](matrix-org/matrix-react-sdk#7073)). Fixes element-hq#19528.
* Tweaks to informational architecture 1.1 ([\element-hq#7052](matrix-org/matrix-react-sdk#7052)). Fixes element-hq#19526, element-hq#19379, element-hq#17792, element-hq#16450, element-hq#19881, element-hq#19892, element-hq#19300, element-hq#19324, element-hq#17307, element-hq#17468 element-hq#19932 and element-hq#19956.
* [Release] Fix inline code block nowrap issue ([\element-hq#7407](matrix-org/matrix-react-sdk#7407)).
* don't collapse spaces in inline code blocks (https ([\element-hq#7328](matrix-org/matrix-react-sdk#7328)). Fixes element-hq#6051. Contributed by @HarHarLinks.
* Fix accessibility regressions ([\element-hq#7336](matrix-org/matrix-react-sdk#7336)).
* Debounce User Info start dm "Message" button ([\element-hq#7357](matrix-org/matrix-react-sdk#7357)). Fixes element-hq#7763.
* Fix thread filter being cut-off on narrow screens ([\element-hq#7354](matrix-org/matrix-react-sdk#7354)). Fixes element-hq#20146.
* Fix upgraded rooms wrongly showing up in spotlight ([\element-hq#7341](matrix-org/matrix-react-sdk#7341)). Fixes element-hq#20141.
* Show votes in replied-to polls (pass in getRelationsForEvent) ([\element-hq#7345](matrix-org/matrix-react-sdk#7345)). Fixes element-hq#20153.
* Keep all previously approved widget capabilities when requesting new capabilities ([\element-hq#7340](matrix-org/matrix-react-sdk#7340)). Contributed by @dhenneke.
* Only show poll previews when the polls feature is enabled ([\element-hq#7331](matrix-org/matrix-react-sdk#7331)).
* No-op action:join if the user is already invited for scalar ([\element-hq#7334](matrix-org/matrix-react-sdk#7334)). Fixes element-hq#20134.
* Don't show polls in timeline if polls are disabled ([\element-hq#7332](matrix-org/matrix-react-sdk#7332)). Fixes element-hq#20130.
* Don't send a poll response event if you are voting for your current c… ([\element-hq#7326](matrix-org/matrix-react-sdk#7326)). Fixes element-hq#20129.
* Don't show options button when the user can't modify widgets ([\element-hq#7324](matrix-org/matrix-react-sdk#7324)). Fixes element-hq#20114. Contributed by @SimonBrandner.
* Add vertical spacing between buttons when they go over multiple lines ([\element-hq#7314](matrix-org/matrix-react-sdk#7314)). Contributed by @twigleingrid.
* Improve accessibility of opening space create menu ([\element-hq#7316](matrix-org/matrix-react-sdk#7316)).
* Correct tab order in room preview dialog ([\element-hq#7302](matrix-org/matrix-react-sdk#7302)).
* Fix favourites and people metaspaces not rendering their content ([\#7315](matrix-org/matrix-react-sdk#7315)). Fixes element-hq#20070.
* Make clear button images visible in high contrast theme ([\element-hq#7306](matrix-org/matrix-react-sdk#7306)). Fixes element-hq#19931.
* Fix html exporting and improve output size ([\element-hq#7312](matrix-org/matrix-react-sdk#7312)). Fixes element-hq#19436 element-hq#20107 and element-hq#19441.
* Fix textual message stripping new line ([\element-hq#7239](matrix-org/matrix-react-sdk#7239)). Fixes element-hq#15320. Contributed by @renancleyson-dev.
* Fix issue with room list resizer getting clipped in firefox ([\element-hq#7303](matrix-org/matrix-react-sdk#7303)). Fixes element-hq#20076.
* Fix wrong indentation with nested ordered list unnesting list on edit ([\element-hq#7300](matrix-org/matrix-react-sdk#7300)). Contributed by @renancleyson-dev.
* Fix input field behaviour inside context menus ([\element-hq#7293](matrix-org/matrix-react-sdk#7293)). Fixes element-hq#19881.
* Corrected the alignment of the Edit button on LoginPage. ([\element-hq#7292](matrix-org/matrix-react-sdk#7292)). Contributed by @ankur12-1610.
* Allow sharing manual location without giving location permission ([\element-hq#7295](matrix-org/matrix-react-sdk#7295)). Fixes element-hq#20065. Contributed by @tulir.
* Make emoji picker search placeholder localizable ([\element-hq#7294](matrix-org/matrix-react-sdk#7294)).
* Fix jump to bottom on message send ([\element-hq#7280](matrix-org/matrix-react-sdk#7280)). Fixes element-hq#19859. Contributed by @SimonBrandner.
* Fix: Warning: Unsupported style property pointer-events. Did you mean pointerEvents? ([\element-hq#7291](matrix-org/matrix-react-sdk#7291)).
* Add edits and replies to the right panel timeline & prepare the timelineCard to share code with threads ([\element-hq#7262](matrix-org/matrix-react-sdk#7262)). Fixes element-hq#20012 and element-hq#19928.
* Fix labs exploding when lab group is empty ([\element-hq#7290](matrix-org/matrix-react-sdk#7290)). Fixes element-hq#20051.
* Update URL when room aliases are modified ([\element-hq#7289](matrix-org/matrix-react-sdk#7289)). Fixes element-hq#1616 and element-hq#1925.
* Render mini user menu for when space panel is disabled ([\element-hq#7258](matrix-org/matrix-react-sdk#7258)). Fixes element-hq#19998.
* When accepting DM from People metaspace don't switch to Home ([\element-hq#7272](matrix-org/matrix-react-sdk#7272)). Fixes element-hq#19995.
* Fix CallPreview `room is null` ([\element-hq#7265](matrix-org/matrix-react-sdk#7265)). Fixes element-hq#19990, element-hq#19972, matrix-org/element-web-rageshakes#7004 matrix-org/element-web-rageshakes#6991 and matrix-org/element-web-rageshakes#6964.
* Fixes more instances of double-translation ([\element-hq#7259](matrix-org/matrix-react-sdk#7259)). Fixes element-hq#20010.
* Fix video calls ([\element-hq#7256](matrix-org/matrix-react-sdk#7256)). Fixes element-hq#20008. Contributed by @SimonBrandner.
* Fix broken i18n in Forgot & Change password ([\element-hq#7252](matrix-org/matrix-react-sdk#7252)). Fixes element-hq#19989.
* Fix setBotPower to not use `.content` ([\element-hq#7179](matrix-org/matrix-react-sdk#7179)). Fixes element-hq#19845.
* Break long words in pinned messages to prevent overflow ([\element-hq#7251](matrix-org/matrix-react-sdk#7251)). Fixes element-hq#19985.
* Disallow sending empty feedbacks ([\element-hq#7240](matrix-org/matrix-react-sdk#7240)).
* Fix wrongly sized default sub-space icons in space panel ([\element-hq#7243](matrix-org/matrix-react-sdk#7243)). Fixes element-hq#19973.
* Hide clear cache and reload button if crash is before client init ([\element-hq#7242](matrix-org/matrix-react-sdk#7242)). Fixes matrix-org/element-web-rageshakes#6996.
* Fix automatic space switching wrongly going via Home for room aliases ([\element-hq#7247](matrix-org/matrix-react-sdk#7247)). Fixes element-hq#19974.
* Fix links being parsed as markdown links improperly ([\element-hq#7200](matrix-org/matrix-react-sdk#7200)). Contributed by @Palid.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request Dec 21, 2021
@su-ex
Merge tag 'v3.37.0' into sc
75256bf 
* Always unhide widgets on layout change (pinning a widget) ([\matrix-org#7299](matrix-org#7299)).
* Update status message in the member list and user info panel when it is changed ([\matrix-org#7338](matrix-org#7338)). Fixes element-hq/element-web#20127. Contributed by @SimonBrandner.
* Iterate space panel toggle collapse interaction ([\matrix-org#7335](matrix-org#7335)). Fixes element-hq/element-web#20079.
* Spotlight search labs ([\matrix-org#7116](matrix-org#7116)). Fixes element-hq/element-web#19530.
* Put room settings form elements in fieldsets ([\matrix-org#7311](matrix-org#7311)).
* Add descriptions to ambiguous links for screen readers ([\matrix-org#7310](matrix-org#7310)).
* Make tooltips keyboard accessible ([\matrix-org#7281](matrix-org#7281)).
* Iterate room context menus for DMs ([\matrix-org#7308](matrix-org#7308)). Fixes element-hq/element-web#19527.
* Update space panel expand mechanism ([\matrix-org#7230](matrix-org#7230)). Fixes element-hq/element-web#17993.
* Add CSS variable to make the UI gaps consistent and fix the resize handle position ([\matrix-org#7234](matrix-org#7234)). Fixes element-hq/element-web#19904 and element-hq/element-web#19938.
* Custom location sharing. ([\matrix-org#7185](matrix-org#7185)).
* Simple static location sharing ([\matrix-org#7135](matrix-org#7135)).
* Finish sending pending messages before leaving room ([\matrix-org#7276](matrix-org#7276)). Fixes element-hq/element-web#4702.
* Dropdown follow wai-aria practices for expanding on arrow keys ([\matrix-org#7277](matrix-org#7277)). Fixes element-hq/element-web#3687.
* Expose PL control for pinned events when lab enabled ([\matrix-org#7278](matrix-org#7278)). Fixes element-hq/element-web#5396.
* In People & Favourites metaspaces always show all rooms ([\matrix-org#7288](matrix-org#7288)). Fixes element-hq/element-web#20048.
* Don't allow calls when the connection the server has been lost ([\matrix-org#7287](matrix-org#7287)). Fixes element-hq/element-web#2096. Contributed by @SimonBrandner.
* Analytics opt in for posthog ([\matrix-org#6936](matrix-org#6936)).
* Don't inhibit current room notifications if user has Modal open ([\matrix-org#7274](matrix-org#7274)). Fixes element-hq/element-web#1118.
* Remove the `Screen sharing is here!` dialog ([\matrix-org#7266](matrix-org#7266)). Fixes element-hq/element-web#18824. Contributed by @SimonBrandner.
* Make composer buttons react to settings without having to change room ([\matrix-org#7264](matrix-org#7264)). Fixes element-hq/element-web#20011.
* Decorate view keyboard shortcuts link as a link ([\matrix-org#7260](matrix-org#7260)). Fixes element-hq/element-web#20007.
* Improve ease of focusing on Room list Search ([\matrix-org#7255](matrix-org#7255)). Fixes matrix-org/element-web-rageshakes#7017.
* Autofocus device panel entry when renaming device ([\matrix-org#7249](matrix-org#7249)). Fixes element-hq/element-web#19984.
* Update Space Panel scrollable region ([\matrix-org#7245](matrix-org#7245)). Fixes element-hq/element-web#19978.
* Replace breadcrumbs with recently viewed menu ([\matrix-org#7073](matrix-org#7073)). Fixes element-hq/element-web#19528.
* Tweaks to informational architecture 1.1 ([\matrix-org#7052](matrix-org#7052)). Fixes element-hq/element-web#19526, element-hq/element-web#19379, element-hq/element-web#17792, element-hq/element-web#16450, element-hq/element-web#19881, element-hq/element-web#19892, element-hq/element-web#19300, element-hq/element-web#19324, element-hq/element-web#17307, element-hq/element-web#17468 element-hq/element-web#19932 and element-hq/element-web#19956.
* [Release] Fix inline code block nowrap issue ([\matrix-org#7407](matrix-org#7407)).
* don't collapse spaces in inline code blocks (https ([\matrix-org#7328](matrix-org#7328)). Fixes element-hq/element-web#6051. Contributed by @HarHarLinks.
* Fix accessibility regressions ([\matrix-org#7336](matrix-org#7336)).
* Debounce User Info start dm "Message" button ([\matrix-org#7357](matrix-org#7357)). Fixes element-hq/element-web#7763.
* Fix thread filter being cut-off on narrow screens ([\matrix-org#7354](matrix-org#7354)). Fixes element-hq/element-web#20146.
* Fix upgraded rooms wrongly showing up in spotlight ([\matrix-org#7341](matrix-org#7341)). Fixes element-hq/element-web#20141.
* Show votes in replied-to polls (pass in getRelationsForEvent) ([\matrix-org#7345](matrix-org#7345)). Fixes element-hq/element-web#20153.
* Keep all previously approved widget capabilities when requesting new capabilities ([\matrix-org#7340](matrix-org#7340)). Contributed by @dhenneke.
* Only show poll previews when the polls feature is enabled ([\matrix-org#7331](matrix-org#7331)).
* No-op action:join if the user is already invited for scalar ([\matrix-org#7334](matrix-org#7334)). Fixes element-hq/element-web#20134.
* Don't show polls in timeline if polls are disabled ([\matrix-org#7332](matrix-org#7332)). Fixes element-hq/element-web#20130.
* Don't send a poll response event if you are voting for your current c… ([\matrix-org#7326](matrix-org#7326)). Fixes element-hq/element-web#20129.
* Don't show options button when the user can't modify widgets ([\matrix-org#7324](matrix-org#7324)). Fixes element-hq/element-web#20114. Contributed by @SimonBrandner.
* Add vertical spacing between buttons when they go over multiple lines ([\matrix-org#7314](matrix-org#7314)). Contributed by @twigleingrid.
* Improve accessibility of opening space create menu ([\matrix-org#7316](matrix-org#7316)).
* Correct tab order in room preview dialog ([\matrix-org#7302](matrix-org#7302)).
* Fix favourites and people metaspaces not rendering their content ([\matrix-org#7315](matrix-org#7315)). Fixes element-hq/element-web#20070.
* Make clear button images visible in high contrast theme ([\matrix-org#7306](matrix-org#7306)). Fixes element-hq/element-web#19931.
* Fix html exporting and improve output size ([\matrix-org#7312](matrix-org#7312)). Fixes element-hq/element-web#19436 element-hq/element-web#20107 and element-hq/element-web#19441.
* Fix textual message stripping new line ([\matrix-org#7239](matrix-org#7239)). Fixes element-hq/element-web#15320. Contributed by @renancleyson-dev.
* Fix issue with room list resizer getting clipped in firefox ([\matrix-org#7303](matrix-org#7303)). Fixes element-hq/element-web#20076.
* Fix wrong indentation with nested ordered list unnesting list on edit ([\matrix-org#7300](matrix-org#7300)). Contributed by @renancleyson-dev.
* Fix input field behaviour inside context menus ([\matrix-org#7293](matrix-org#7293)). Fixes element-hq/element-web#19881.
* Corrected the alignment of the Edit button on LoginPage. ([\matrix-org#7292](matrix-org#7292)). Contributed by @ankur12-1610.
* Allow sharing manual location without giving location permission ([\matrix-org#7295](matrix-org#7295)). Fixes element-hq/element-web#20065. Contributed by @tulir.
* Make emoji picker search placeholder localizable ([\matrix-org#7294](matrix-org#7294)).
* Fix jump to bottom on message send ([\matrix-org#7280](matrix-org#7280)). Fixes element-hq/element-web#19859. Contributed by @SimonBrandner.
* Fix: Warning: Unsupported style property pointer-events. Did you mean pointerEvents? ([\matrix-org#7291](matrix-org#7291)).
* Add edits and replies to the right panel timeline & prepare the timelineCard to share code with threads ([\matrix-org#7262](matrix-org#7262)). Fixes element-hq/element-web#20012 and element-hq/element-web#19928.
* Fix labs exploding when lab group is empty ([\matrix-org#7290](matrix-org#7290)). Fixes element-hq/element-web#20051.
* Update URL when room aliases are modified ([\matrix-org#7289](matrix-org#7289)). Fixes element-hq/element-web#1616 and element-hq/element-web#1925.
* Render mini user menu for when space panel is disabled ([\matrix-org#7258](matrix-org#7258)). Fixes element-hq/element-web#19998.
* When accepting DM from People metaspace don't switch to Home ([\matrix-org#7272](matrix-org#7272)). Fixes element-hq/element-web#19995.
* Fix CallPreview `room is null` ([\matrix-org#7265](matrix-org#7265)). Fixes element-hq/element-web#19990, element-hq/element-web#19972, matrix-org/element-web-rageshakes#7004 matrix-org/element-web-rageshakes#6991 and matrix-org/element-web-rageshakes#6964.
* Fixes more instances of double-translation ([\matrix-org#7259](matrix-org#7259)). Fixes element-hq/element-web#20010.
* Fix video calls ([\matrix-org#7256](matrix-org#7256)). Fixes element-hq/element-web#20008. Contributed by @SimonBrandner.
* Fix broken i18n in Forgot & Change password ([\matrix-org#7252](matrix-org#7252)). Fixes element-hq/element-web#19989.
* Fix setBotPower to not use `.content` ([\matrix-org#7179](matrix-org#7179)). Fixes element-hq/element-web#19845.
* Break long words in pinned messages to prevent overflow ([\matrix-org#7251](matrix-org#7251)). Fixes element-hq/element-web#19985.
* Disallow sending empty feedbacks ([\matrix-org#7240](matrix-org#7240)).
* Fix wrongly sized default sub-space icons in space panel ([\matrix-org#7243](matrix-org#7243)). Fixes element-hq/element-web#19973.
* Hide clear cache and reload button if crash is before client init ([\matrix-org#7242](matrix-org#7242)). Fixes matrix-org/element-web-rageshakes#6996.
* Fix automatic space switching wrongly going via Home for room aliases ([\matrix-org#7247](matrix-org#7247)). Fixes element-hq/element-web#19974.
* Fix links being parsed as markdown links improperly ([\matrix-org#7200](matrix-org#7200)). Contributed by @Palid.
su-ex added a commit to SchildiChat/element-desktop that referenced this pull request Dec 21, 2021
@su-ex
Merge tag 'v1.9.8' into sc
f038ba4 
* Include Vietnamese language ([\#20029](element-hq/element-web#20029)).
* Simple static location sharing ([\#19754](element-hq/element-web#19754)).
* Add support for the Indonesian language ([\#20032](element-hq/element-web#20032)). Fixes element-hq/element-web#20030. Contributed by @Linerly.
* Always unhide widgets on layout change (pinning a widget) ([\#7299](matrix-org/matrix-react-sdk#7299)).
* Update status message in the member list and user info panel when it is changed ([\#7338](matrix-org/matrix-react-sdk#7338)). Fixes element-hq/element-web#20127. Contributed by @SimonBrandner.
* Iterate space panel toggle collapse interaction ([\#7335](matrix-org/matrix-react-sdk#7335)). Fixes element-hq/element-web#20079.
* Spotlight search labs ([\#7116](matrix-org/matrix-react-sdk#7116)). Fixes element-hq/element-web#19530.
* Put room settings form elements in fieldsets ([\#7311](matrix-org/matrix-react-sdk#7311)).
* Add descriptions to ambiguous links for screen readers ([\#7310](matrix-org/matrix-react-sdk#7310)).
* Make tooltips keyboard accessible ([\#7281](matrix-org/matrix-react-sdk#7281)).
* Iterate room context menus for DMs ([\#7308](matrix-org/matrix-react-sdk#7308)). Fixes element-hq/element-web#19527.
* Update space panel expand mechanism ([\#7230](matrix-org/matrix-react-sdk#7230)). Fixes element-hq/element-web#17993.
* Add CSS variable to make the UI gaps consistent and fix the resize handle position ([\#7234](matrix-org/matrix-react-sdk#7234)). Fixes element-hq/element-web#19904 and element-hq/element-web#19938.
* Custom location sharing. ([\#7185](matrix-org/matrix-react-sdk#7185)).
* Simple static location sharing ([\#7135](matrix-org/matrix-react-sdk#7135)).
* Finish sending pending messages before leaving room ([\#7276](matrix-org/matrix-react-sdk#7276)). Fixes element-hq/element-web#4702.
* Dropdown follow wai-aria practices for expanding on arrow keys ([\#7277](matrix-org/matrix-react-sdk#7277)). Fixes element-hq/element-web#3687.
* Expose PL control for pinned events when lab enabled ([\#7278](matrix-org/matrix-react-sdk#7278)). Fixes element-hq/element-web#5396.
* In People & Favourites metaspaces always show all rooms ([\#7288](matrix-org/matrix-react-sdk#7288)). Fixes element-hq/element-web#20048.
* Don't allow calls when the connection the server has been lost ([\#7287](matrix-org/matrix-react-sdk#7287)). Fixes element-hq/element-web#2096. Contributed by @SimonBrandner.
* Analytics opt in for posthog ([\#6936](matrix-org/matrix-react-sdk#6936)).
* Don't inhibit current room notifications if user has Modal open ([\#7274](matrix-org/matrix-react-sdk#7274)). Fixes element-hq/element-web#1118.
* Remove the `Screen sharing is here!` dialog ([\#7266](matrix-org/matrix-react-sdk#7266)). Fixes element-hq/element-web#18824. Contributed by @SimonBrandner.
* Make composer buttons react to settings without having to change room ([\#7264](matrix-org/matrix-react-sdk#7264)). Fixes element-hq/element-web#20011.
* Decorate view keyboard shortcuts link as a link ([\#7260](matrix-org/matrix-react-sdk#7260)). Fixes element-hq/element-web#20007.
* Improve ease of focusing on Room list Search ([\#7255](matrix-org/matrix-react-sdk#7255)). Fixes matrix-org/element-web-rageshakes#7017.
* Autofocus device panel entry when renaming device ([\#7249](matrix-org/matrix-react-sdk#7249)). Fixes element-hq/element-web#19984.
* Update Space Panel scrollable region ([\#7245](matrix-org/matrix-react-sdk#7245)). Fixes element-hq/element-web#19978.
* Replace breadcrumbs with recently viewed menu ([\#7073](matrix-org/matrix-react-sdk#7073)). Fixes element-hq/element-web#19528.
* Tweaks to informational architecture 1.1 ([\#7052](matrix-org/matrix-react-sdk#7052)). Fixes element-hq/element-web#19526, element-hq/element-web#19379, element-hq/element-web#17792, element-hq/element-web#16450, element-hq/element-web#19881, element-hq/element-web#19892, element-hq/element-web#19300, element-hq/element-web#19324, element-hq/element-web#17307, element-hq/element-web#17468 element-hq/element-web#19932 and element-hq/element-web#19956.
* Enable webgl ([\element-hq#284](element-hq#284)). Fixes element-hq/element-web#20132. Contributed by @SimonBrandner.
* [Release] Fix inline code block nowrap issue ([\#7407](matrix-org/matrix-react-sdk#7407)).
* don't collapse spaces in inline code blocks (https ([\#7328](matrix-org/matrix-react-sdk#7328)). Fixes element-hq/element-web#6051. Contributed by @HarHarLinks.
* Fix accessibility regressions ([\#7336](matrix-org/matrix-react-sdk#7336)).
* Debounce User Info start dm "Message" button ([\#7357](matrix-org/matrix-react-sdk#7357)). Fixes element-hq/element-web#7763.
* Fix thread filter being cut-off on narrow screens ([\#7354](matrix-org/matrix-react-sdk#7354)). Fixes element-hq/element-web#20146.
* Fix upgraded rooms wrongly showing up in spotlight ([\#7341](matrix-org/matrix-react-sdk#7341)). Fixes element-hq/element-web#20141.
* Show votes in replied-to polls (pass in getRelationsForEvent) ([\#7345](matrix-org/matrix-react-sdk#7345)). Fixes element-hq/element-web#20153.
* Keep all previously approved widget capabilities when requesting new capabilities ([\#7340](matrix-org/matrix-react-sdk#7340)). Contributed by @dhenneke.
* Only show poll previews when the polls feature is enabled ([\#7331](matrix-org/matrix-react-sdk#7331)).
* No-op action:join if the user is already invited for scalar ([\#7334](matrix-org/matrix-react-sdk#7334)). Fixes element-hq/element-web#20134.
* Don't show polls in timeline if polls are disabled ([\#7332](matrix-org/matrix-react-sdk#7332)). Fixes element-hq/element-web#20130.
* Don't send a poll response event if you are voting for your current c… ([\#7326](matrix-org/matrix-react-sdk#7326)). Fixes element-hq/element-web#20129.
* Don't show options button when the user can't modify widgets ([\#7324](matrix-org/matrix-react-sdk#7324)). Fixes element-hq/element-web#20114. Contributed by @SimonBrandner.
* Add vertical spacing between buttons when they go over multiple lines ([\#7314](matrix-org/matrix-react-sdk#7314)). Contributed by @twigleingrid.
* Improve accessibility of opening space create menu ([\#7316](matrix-org/matrix-react-sdk#7316)).
* Correct tab order in room preview dialog ([\#7302](matrix-org/matrix-react-sdk#7302)).
* Fix favourites and people metaspaces not rendering their content ([\#7315](matrix-org/matrix-react-sdk#7315)). Fixes element-hq/element-web#20070.
* Make clear button images visible in high contrast theme ([\#7306](matrix-org/matrix-react-sdk#7306)). Fixes element-hq/element-web#19931.
* Fix html exporting and improve output size ([\#7312](matrix-org/matrix-react-sdk#7312)). Fixes element-hq/element-web#19436 element-hq/element-web#20107 and element-hq/element-web#19441.
* Fix textual message stripping new line ([\#7239](matrix-org/matrix-react-sdk#7239)). Fixes element-hq/element-web#15320. Contributed by @renancleyson-dev.
* Fix issue with room list resizer getting clipped in firefox ([\#7303](matrix-org/matrix-react-sdk#7303)). Fixes element-hq/element-web#20076.
* Fix wrong indentation with nested ordered list unnesting list on edit ([\#7300](matrix-org/matrix-react-sdk#7300)). Contributed by @renancleyson-dev.
* Fix input field behaviour inside context menus ([\#7293](matrix-org/matrix-react-sdk#7293)). Fixes element-hq/element-web#19881.
* Corrected the alignment of the Edit button on LoginPage. ([\#7292](matrix-org/matrix-react-sdk#7292)). Contributed by @ankur12-1610.
* Allow sharing manual location without giving location permission ([\#7295](matrix-org/matrix-react-sdk#7295)). Fixes element-hq/element-web#20065. Contributed by @tulir.
* Make emoji picker search placeholder localizable ([\#7294](matrix-org/matrix-react-sdk#7294)).
* Fix jump to bottom on message send ([\#7280](matrix-org/matrix-react-sdk#7280)). Fixes element-hq/element-web#19859. Contributed by @SimonBrandner.
* Fix: Warning: Unsupported style property pointer-events. Did you mean pointerEvents? ([\#7291](matrix-org/matrix-react-sdk#7291)).
* Add edits and replies to the right panel timeline & prepare the timelineCard to share code with threads ([\#7262](matrix-org/matrix-react-sdk#7262)). Fixes element-hq/element-web#20012 and element-hq/element-web#19928.
* Fix labs exploding when lab group is empty ([\#7290](matrix-org/matrix-react-sdk#7290)). Fixes element-hq/element-web#20051.
* Update URL when room aliases are modified ([\#7289](matrix-org/matrix-react-sdk#7289)). Fixes element-hq/element-web#1616 and element-hq/element-web#1925.
* Render mini user menu for when space panel is disabled ([\#7258](matrix-org/matrix-react-sdk#7258)). Fixes element-hq/element-web#19998.
* When accepting DM from People metaspace don't switch to Home ([\#7272](matrix-org/matrix-react-sdk#7272)). Fixes element-hq/element-web#19995.
* Fix CallPreview `room is null` ([\#7265](matrix-org/matrix-react-sdk#7265)). Fixes element-hq/element-web#19990, element-hq/element-web#19972, matrix-org/element-web-rageshakes#7004 matrix-org/element-web-rageshakes#6991 and matrix-org/element-web-rageshakes#6964.
* Fixes more instances of double-translation ([\#7259](matrix-org/matrix-react-sdk#7259)). Fixes element-hq/element-web#20010.
* Fix video calls ([\#7256](matrix-org/matrix-react-sdk#7256)). Fixes element-hq/element-web#20008. Contributed by @SimonBrandner.
* Fix broken i18n in Forgot & Change password ([\#7252](matrix-org/matrix-react-sdk#7252)). Fixes element-hq/element-web#19989.
* Fix setBotPower to not use `.content` ([\#7179](matrix-org/matrix-react-sdk#7179)). Fixes element-hq/element-web#19845.
* Break long words in pinned messages to prevent overflow ([\#7251](matrix-org/matrix-react-sdk#7251)). Fixes element-hq/element-web#19985.
* Disallow sending empty feedbacks ([\#7240](matrix-org/matrix-react-sdk#7240)).
* Fix wrongly sized default sub-space icons in space panel ([\#7243](matrix-org/matrix-react-sdk#7243)). Fixes element-hq/element-web#19973.
* Hide clear cache and reload button if crash is before client init ([\#7242](matrix-org/matrix-react-sdk#7242)). Fixes matrix-org/element-web-rageshakes#6996.
* Fix automatic space switching wrongly going via Home for room aliases ([\#7247](matrix-org/matrix-react-sdk#7247)). Fixes element-hq/element-web#19974.
* Fix links being parsed as markdown links improperly ([\#7200](matrix-org/matrix-react-sdk#7200)). Contributed by @Palid.
su-ex added a commit to SchildiChat/element-web that referenced this pull request Dec 21, 2021
@su-ex
Merge tag 'v1.9.8' into sc
73b0c22 
* Include Vietnamese language ([\element-hq#20029](element-hq#20029)).
* Simple static location sharing ([\element-hq#19754](element-hq#19754)).
* Add support for the Indonesian language ([\element-hq#20032](element-hq#20032)). Fixes element-hq#20030. Contributed by @Linerly.
* Always unhide widgets on layout change (pinning a widget) ([\element-hq#7299](matrix-org/matrix-react-sdk#7299)).
* Update status message in the member list and user info panel when it is changed ([\element-hq#7338](matrix-org/matrix-react-sdk#7338)). Fixes element-hq#20127. Contributed by @SimonBrandner.
* Iterate space panel toggle collapse interaction ([\element-hq#7335](matrix-org/matrix-react-sdk#7335)). Fixes element-hq#20079.
* Spotlight search labs ([\element-hq#7116](matrix-org/matrix-react-sdk#7116)). Fixes element-hq#19530.
* Put room settings form elements in fieldsets ([\element-hq#7311](matrix-org/matrix-react-sdk#7311)).
* Add descriptions to ambiguous links for screen readers ([\element-hq#7310](matrix-org/matrix-react-sdk#7310)).
* Make tooltips keyboard accessible ([\#7281](matrix-org/matrix-react-sdk#7281)).
* Iterate room context menus for DMs ([\element-hq#7308](matrix-org/matrix-react-sdk#7308)). Fixes element-hq#19527.
* Update space panel expand mechanism ([\element-hq#7230](matrix-org/matrix-react-sdk#7230)). Fixes element-hq#17993.
* Add CSS variable to make the UI gaps consistent and fix the resize handle position ([\element-hq#7234](matrix-org/matrix-react-sdk#7234)). Fixes element-hq#19904 and element-hq#19938.
* Custom location sharing. ([\element-hq#7185](matrix-org/matrix-react-sdk#7185)).
* Simple static location sharing ([\element-hq#7135](matrix-org/matrix-react-sdk#7135)).
* Finish sending pending messages before leaving room ([\element-hq#7276](matrix-org/matrix-react-sdk#7276)). Fixes element-hq#4702.
* Dropdown follow wai-aria practices for expanding on arrow keys ([\element-hq#7277](matrix-org/matrix-react-sdk#7277)). Fixes element-hq#3687.
* Expose PL control for pinned events when lab enabled ([\element-hq#7278](matrix-org/matrix-react-sdk#7278)). Fixes element-hq#5396.
* In People & Favourites metaspaces always show all rooms ([\element-hq#7288](matrix-org/matrix-react-sdk#7288)). Fixes element-hq#20048.
* Don't allow calls when the connection the server has been lost ([\element-hq#7287](matrix-org/matrix-react-sdk#7287)). Fixes element-hq#2096. Contributed by @SimonBrandner.
* Analytics opt in for posthog ([\element-hq#6936](matrix-org/matrix-react-sdk#6936)).
* Don't inhibit current room notifications if user has Modal open ([\element-hq#7274](matrix-org/matrix-react-sdk#7274)). Fixes element-hq#1118.
* Remove the `Screen sharing is here!` dialog ([\#7266](matrix-org/matrix-react-sdk#7266)). Fixes element-hq#18824. Contributed by @SimonBrandner.
* Make composer buttons react to settings without having to change room ([\element-hq#7264](matrix-org/matrix-react-sdk#7264)). Fixes element-hq#20011.
* Decorate view keyboard shortcuts link as a link ([\element-hq#7260](matrix-org/matrix-react-sdk#7260)). Fixes element-hq#20007.
* Improve ease of focusing on Room list Search ([\element-hq#7255](matrix-org/matrix-react-sdk#7255)). Fixes matrix-org/element-web-rageshakes#7017.
* Autofocus device panel entry when renaming device ([\element-hq#7249](matrix-org/matrix-react-sdk#7249)). Fixes element-hq#19984.
* Update Space Panel scrollable region ([\element-hq#7245](matrix-org/matrix-react-sdk#7245)). Fixes element-hq#19978.
* Replace breadcrumbs with recently viewed menu ([\element-hq#7073](matrix-org/matrix-react-sdk#7073)). Fixes element-hq#19528.
* Tweaks to informational architecture 1.1 ([\element-hq#7052](matrix-org/matrix-react-sdk#7052)). Fixes element-hq#19526, element-hq#19379, element-hq#17792, element-hq#16450, element-hq#19881, element-hq#19892, element-hq#19300, element-hq#19324, element-hq#17307, element-hq#17468 element-hq#19932 and element-hq#19956.
* [Release] Fix inline code block nowrap issue ([\element-hq#7407](matrix-org/matrix-react-sdk#7407)).
* don't collapse spaces in inline code blocks (https ([\element-hq#7328](matrix-org/matrix-react-sdk#7328)). Fixes element-hq#6051. Contributed by @HarHarLinks.
* Fix accessibility regressions ([\element-hq#7336](matrix-org/matrix-react-sdk#7336)).
* Debounce User Info start dm "Message" button ([\element-hq#7357](matrix-org/matrix-react-sdk#7357)). Fixes element-hq#7763.
* Fix thread filter being cut-off on narrow screens ([\element-hq#7354](matrix-org/matrix-react-sdk#7354)). Fixes element-hq#20146.
* Fix upgraded rooms wrongly showing up in spotlight ([\element-hq#7341](matrix-org/matrix-react-sdk#7341)). Fixes element-hq#20141.
* Show votes in replied-to polls (pass in getRelationsForEvent) ([\element-hq#7345](matrix-org/matrix-react-sdk#7345)). Fixes element-hq#20153.
* Keep all previously approved widget capabilities when requesting new capabilities ([\element-hq#7340](matrix-org/matrix-react-sdk#7340)). Contributed by @dhenneke.
* Only show poll previews when the polls feature is enabled ([\element-hq#7331](matrix-org/matrix-react-sdk#7331)).
* No-op action:join if the user is already invited for scalar ([\element-hq#7334](matrix-org/matrix-react-sdk#7334)). Fixes element-hq#20134.
* Don't show polls in timeline if polls are disabled ([\element-hq#7332](matrix-org/matrix-react-sdk#7332)). Fixes element-hq#20130.
* Don't send a poll response event if you are voting for your current c… ([\element-hq#7326](matrix-org/matrix-react-sdk#7326)). Fixes element-hq#20129.
* Don't show options button when the user can't modify widgets ([\element-hq#7324](matrix-org/matrix-react-sdk#7324)). Fixes element-hq#20114. Contributed by @SimonBrandner.
* Add vertical spacing between buttons when they go over multiple lines ([\element-hq#7314](matrix-org/matrix-react-sdk#7314)). Contributed by @twigleingrid.
* Improve accessibility of opening space create menu ([\element-hq#7316](matrix-org/matrix-react-sdk#7316)).
* Correct tab order in room preview dialog ([\element-hq#7302](matrix-org/matrix-react-sdk#7302)).
* Fix favourites and people metaspaces not rendering their content ([\#7315](matrix-org/matrix-react-sdk#7315)). Fixes element-hq#20070.
* Make clear button images visible in high contrast theme ([\element-hq#7306](matrix-org/matrix-react-sdk#7306)). Fixes element-hq#19931.
* Fix html exporting and improve output size ([\element-hq#7312](matrix-org/matrix-react-sdk#7312)). Fixes element-hq#19436 element-hq#20107 and element-hq#19441.
* Fix textual message stripping new line ([\element-hq#7239](matrix-org/matrix-react-sdk#7239)). Fixes element-hq#15320. Contributed by @renancleyson-dev.
* Fix issue with room list resizer getting clipped in firefox ([\element-hq#7303](matrix-org/matrix-react-sdk#7303)). Fixes element-hq#20076.
* Fix wrong indentation with nested ordered list unnesting list on edit ([\element-hq#7300](matrix-org/matrix-react-sdk#7300)). Contributed by @renancleyson-dev.
* Fix input field behaviour inside context menus ([\element-hq#7293](matrix-org/matrix-react-sdk#7293)). Fixes element-hq#19881.
* Corrected the alignment of the Edit button on LoginPage. ([\element-hq#7292](matrix-org/matrix-react-sdk#7292)). Contributed by @ankur12-1610.
* Allow sharing manual location without giving location permission ([\element-hq#7295](matrix-org/matrix-react-sdk#7295)). Fixes element-hq#20065. Contributed by @tulir.
* Make emoji picker search placeholder localizable ([\element-hq#7294](matrix-org/matrix-react-sdk#7294)).
* Fix jump to bottom on message send ([\element-hq#7280](matrix-org/matrix-react-sdk#7280)). Fixes element-hq#19859. Contributed by @SimonBrandner.
* Fix: Warning: Unsupported style property pointer-events. Did you mean pointerEvents? ([\element-hq#7291](matrix-org/matrix-react-sdk#7291)).
* Add edits and replies to the right panel timeline & prepare the timelineCard to share code with threads ([\element-hq#7262](matrix-org/matrix-react-sdk#7262)). Fixes element-hq#20012 and element-hq#19928.
* Fix labs exploding when lab group is empty ([\element-hq#7290](matrix-org/matrix-react-sdk#7290)). Fixes element-hq#20051.
* Update URL when room aliases are modified ([\element-hq#7289](matrix-org/matrix-react-sdk#7289)). Fixes element-hq#1616 and element-hq#1925.
* Render mini user menu for when space panel is disabled ([\element-hq#7258](matrix-org/matrix-react-sdk#7258)). Fixes element-hq#19998.
* When accepting DM from People metaspace don't switch to Home ([\element-hq#7272](matrix-org/matrix-react-sdk#7272)). Fixes element-hq#19995.
* Fix CallPreview `room is null` ([\element-hq#7265](matrix-org/matrix-react-sdk#7265)). Fixes element-hq#19990, element-hq#19972, matrix-org/element-web-rageshakes#7004 matrix-org/element-web-rageshakes#6991 and matrix-org/element-web-rageshakes#6964.
* Fixes more instances of double-translation ([\element-hq#7259](matrix-org/matrix-react-sdk#7259)). Fixes element-hq#20010.
* Fix video calls ([\element-hq#7256](matrix-org/matrix-react-sdk#7256)). Fixes element-hq#20008. Contributed by @SimonBrandner.
* Fix broken i18n in Forgot & Change password ([\element-hq#7252](matrix-org/matrix-react-sdk#7252)). Fixes element-hq#19989.
* Fix setBotPower to not use `.content` ([\element-hq#7179](matrix-org/matrix-react-sdk#7179)). Fixes element-hq#19845.
* Break long words in pinned messages to prevent overflow ([\element-hq#7251](matrix-org/matrix-react-sdk#7251)). Fixes element-hq#19985.
* Disallow sending empty feedbacks ([\element-hq#7240](matrix-org/matrix-react-sdk#7240)).
* Fix wrongly sized default sub-space icons in space panel ([\element-hq#7243](matrix-org/matrix-react-sdk#7243)). Fixes element-hq#19973.
* Hide clear cache and reload button if crash is before client init ([\element-hq#7242](matrix-org/matrix-react-sdk#7242)). Fixes matrix-org/element-web-rageshakes#6996.
* Fix automatic space switching wrongly going via Home for room aliases ([\element-hq#7247](matrix-org/matrix-react-sdk#7247)). Fixes element-hq#19974.
* Fix links being parsed as markdown links improperly ([\element-hq#7200](matrix-org/matrix-react-sdk#7200)). Contributed by @Palid.
@poiNt3D
Copy link

poiNt3D commented Jan 17, 2022

Can't find the button.

@matrix-org matrix-org locked as resolved and limited conversation to collaborators Jan 17, 2022
@turt2live
Copy link
Member

Please use the community support rooms, like #element-web:matrix.org for support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@andybalaam andybalaam andybalaam approved these changes

@turt2live turt2live turt2live left review comments

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ara4n @turt2live @SimonBrandner @t3chguy @andybalaam @poiNt3D