This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Enable/disable location share button when setting is changed #7545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
approved these changes
Jan 14, 2022
Comment on lines
+352
to
+353
| const showLocationButton = SettingsStore.getValue( | ||
| "feature_location_share"); |
There was a problem hiding this comment.
this looks like it would fit on one line
There was a problem hiding this comment.
Based on "try to keep JavaScript code around the 90 column mark" from the style doc (this is 100 columns), I'd vote for wrapping it.
There was a problem hiding this comment.
Of course, if I had my way we'd have a hard limit at 80 columns except imports and JSX...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://61e185e16a0e260b6b33d67a--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.