This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add analytics for the ViewRoom action #7666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… t3chguy/analytics/view-room � Conflicts: � src/SlashCommands.tsx � src/components/structures/MatrixChat.tsx � src/components/structures/RoomView.tsx � src/components/views/context_menus/RoomContextMenu.tsx � src/components/views/context_menus/SpaceContextMenu.tsx � src/components/views/dialogs/InviteDialog.tsx � src/components/views/dialogs/SpotlightDialog.tsx � src/components/views/right_panel/TimelineCard.tsx � src/components/views/right_panel/UserInfo.tsx � src/components/views/rooms/MessageComposer.tsx � src/components/views/rooms/RecentlyViewedButton.tsx � src/components/views/rooms/RoomBreadcrumbs.tsx � src/components/views/rooms/RoomSublist.tsx � src/components/views/rooms/RoomTile.tsx � src/stores/spaces/SpaceStore.ts
t3chguy
added
the
T-Task
… t3chguy/analytics/view-room � Conflicts: � src/components/structures/RoomDirectory.tsx � src/components/structures/SpaceRoomView.tsx � src/components/views/context_menus/SpaceContextMenu.tsx � src/components/views/rooms/RoomList.tsx � src/components/views/rooms/RoomListHeader.tsx
kerryarchibald
approved these changes
Feb 10, 2022
| deferred_action?: ActionPayload; // Action to fire after MatrixChat handles this ViewRoom action | ||
|
|
||
| // additional parameters for the purpose of metrics & instrumentation | ||
| _trigger: ViewRoomEvent["trigger"]; |
There was a problem hiding this comment.
Should this be optional? It's often set to undefined.
There was a problem hiding this comment.
its non-optional so that every call-site takes care to specify it, even if that specified value is undefined, just to prevent a call site forgetting to specify it
… t3chguy/analytics/view-room
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-analytics-events#18
Part of element-hq/element-web#20613
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr7666--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.