This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 831
Implement changes to MSC2285 (private read receipts) #7993
Merged
SimonBrandner
merged 8 commits into
matrix-org:develop
from
SimonBrandner:feature/private-read-receipts
May 6, 2022
Merged
Implement changes to MSC2285 (private read receipts) #7993
SimonBrandner
merged 8 commits into
matrix-org:develop
from
SimonBrandner:feature/private-read-receipts
May 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
github-actions
bot
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Mar 5, 2022
This was referenced Mar 5, 2022
SimonBrandner
changed the title
Implement changes to MSC2285
Implement changes to MSC2285 (hidden read receipts)
Mar 7, 2022
t3chguy
reviewed
Mar 9, 2022
t3chguy
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
added
the
X-Blocked
The PR cannot move forward in any capacity until an action is made
label
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@
## develop #7993 +/- ##
===========================================
- Coverage 30.85% 30.77% -0.08%
===========================================
Files 893 893
Lines 50793 50778 -15
Branches 12928 12926 -2
===========================================
- Hits 15671 15628 -43
- Misses 35122 35150 +28
|
…read-receipts Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
removed
the
X-Blocked
The PR cannot move forward in any capacity until an action is made
label
May 4, 2022
SimonBrandner
changed the title
Implement changes to MSC2285 (hidden read receipts)
Implement changes to MSC2285 (private read receipts)
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: task
Implement changes to MSC2285 (hidden read receipts)
Requires matrix-org/matrix-js-sdk#2221
Requires matrix-org/synapse#12168
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr7993--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.