Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Implement changes to MSC2285 (private read receipts) #7993

Merged

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Mar 5, 2022

Type: task
Implement changes to MSC2285 (hidden read receipts)
Requires matrix-org/matrix-js-sdk#2221
Requires matrix-org/synapse#12168


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr7993--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 5, 2022
@SimonBrandner SimonBrandner marked this pull request as ready for review March 6, 2022 07:22
@SimonBrandner SimonBrandner requested a review from a team as a code owner March 6, 2022 07:22
@SimonBrandner SimonBrandner changed the title Implement changes to MSC2285 Implement changes to MSC2285 (hidden read receipts) Mar 7, 2022
src/utils/Receipt.ts Outdated Show resolved Hide resolved
src/utils/Receipt.ts Outdated Show resolved Hide resolved
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner added the X-Blocked The PR cannot move forward in any capacity until an action is made label Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #7993 (774fbdc) into develop (3e31fdb) will decrease coverage by 0.07%.
The diff coverage is 30.00%.

❗ Current head 774fbdc differs from pull request most recent head a4c9ba7. Consider uploading reports for the commit a4c9ba7 to get more accurate results

@@             Coverage Diff             @@
##           develop    #7993      +/-   ##
===========================================
- Coverage    30.85%   30.77%   -0.08%     
===========================================
  Files          893      893              
  Lines        50793    50778      -15     
  Branches     12928    12926       -2     
===========================================
- Hits         15671    15628      -43     
- Misses       35122    35150      +28     
Impacted Files Coverage Δ
src/components/structures/MessagePanel.tsx 66.02% <0.00%> (ø)
src/components/structures/TimelinePanel.tsx 1.66% <0.00%> (-0.01%) ⬇️
src/utils/Receipt.ts 0.00% <0.00%> (ø)
src/utils/read-receipts.ts 66.66% <60.00%> (-33.34%) ⬇️
src/components/views/rooms/SearchBar.tsx 0.00% <0.00%> (-89.29%) ⬇️
src/components/views/rooms/ReadReceiptGroup.tsx 8.33% <0.00%> (-21.67%) ⬇️
src/contexts/RoomContext.ts 100.00% <0.00%> (ø)
src/components/structures/RoomView.tsx 29.65% <0.00%> (ø)
src/components/views/right_panel/UserInfo.tsx 29.23% <0.00%> (ø)
... and 2 more

@github-actions github-actions bot temporarily deployed to Netlify April 30, 2022 13:51 Destroyed
…read-receipts

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner removed the X-Blocked The PR cannot move forward in any capacity until an action is made label May 4, 2022
@SimonBrandner SimonBrandner changed the title Implement changes to MSC2285 (hidden read receipts) Implement changes to MSC2285 (private read receipts) May 5, 2022
@SimonBrandner SimonBrandner merged commit 99543a7 into matrix-org:develop May 6, 2022
@SimonBrandner SimonBrandner deleted the feature/private-read-receipts branch May 6, 2022 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants