Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

End to end tests for threads #8267

Merged
merged 12 commits into from
Apr 12, 2022
Merged

End to end tests for threads #8267

merged 12 commits into from
Apr 12, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 8, 2022

Fixes element-hq/element-web#19199
Requires matrix-org/matrix-js-sdk#2286
Requires matrix-org/matrix-js-sdk#2293


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://pr8267--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #8267 (a3a403d) into develop (f648140) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #8267   +/-   ##
========================================
  Coverage    29.43%   29.43%           
========================================
  Files          867      867           
  Lines        49953    49953           
  Branches     12708    12708           
========================================
  Hits         14702    14702           
  Misses       35251    35251           

@t3chguy t3chguy marked this pull request as ready for review April 11, 2022 19:22
@t3chguy t3chguy requested a review from a team as a code owner April 11, 2022 19:22
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

test/end-to-end-tests/src/rest/thread.ts Outdated Show resolved Hide resolved
test/end-to-end-tests/src/rest/room.ts Outdated Show resolved Hide resolved
test/end-to-end-tests/src/rest/thread.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy requested a review from turt2live April 12, 2022 08:41
@t3chguy t3chguy enabled auto-merge (squash) April 12, 2022 08:55
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well that's one way of fixing member access

@t3chguy t3chguy merged commit 82981e4 into develop Apr 12, 2022
@t3chguy t3chguy deleted the t3chguy/fix/19199 branch April 12, 2022 23:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated tests for threads added to our existing E2E suite
2 participants