Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add a test for URL previews being disabled in e2e rooms #8270

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 8, 2022

Regression test for #8227

Not the best test in the world as per comments.

Also add types for react-test-renderer.


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8270--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 8, 2022
@dbkr dbkr requested a review from a team as a code owner April 8, 2022 16:35
@dbkr dbkr force-pushed the dbkr/test_url_previews_start_disabled branch from 54b4c6c to b6240e7 Compare April 8, 2022 17:25
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #8270 (b6240e7) into develop (f63923d) will increase coverage by 0.69%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #8270      +/-   ##
===========================================
+ Coverage    28.60%   29.30%   +0.69%     
===========================================
  Files          862      862              
  Lines        49788    49788              
  Branches     12680    12680              
===========================================
+ Hits         14241    14589     +348     
+ Misses       35547    35199     -348     
Impacted Files Coverage Δ
src/Searching.ts 0.51% <0.00%> (+0.51%) ⬆️
src/stores/OwnBeaconStore.ts 96.73% <0.00%> (+0.54%) ⬆️
src/stores/widgets/WidgetLayoutStore.ts 69.16% <0.00%> (+0.79%) ⬆️
src/components/structures/RoomDirectory.tsx 0.79% <0.00%> (+0.79%) ⬆️
src/stores/right-panel/RightPanelStore.ts 41.75% <0.00%> (+1.03%) ⬆️
src/components/views/rooms/AuxPanel.tsx 1.81% <0.00%> (+1.81%) ⬆️
src/settings/handlers/AccountSettingsHandler.ts 31.09% <0.00%> (+2.52%) ⬆️
src/components/views/elements/EffectsOverlay.tsx 2.77% <0.00%> (+2.77%) ⬆️
src/ContentMessages.ts 4.30% <0.00%> (+2.86%) ⬆️
src/Unread.ts 29.41% <0.00%> (+2.94%) ⬆️
... and 17 more

@dbkr dbkr merged commit 285dc25 into develop Apr 8, 2022
@dbkr dbkr deleted the dbkr/test_url_previews_start_disabled branch April 8, 2022 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants