Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Style 'your settings' in error message as link #8277

Closed
wants to merge 2 commits into from
Closed

Style 'your settings' in error message as link #8277

wants to merge 2 commits into from

Conversation

ttheshreeyasingh
Copy link

@ttheshreeyasingh ttheshreeyasingh commented Apr 10, 2022

"your settings" in the error message is styled as a link. That link opens the user setting jumps to the "Security & Privacy" tab and scrolls down to the "Message search" section.

Fixes issue element-hq/element-web#18164

Signed-off-by: Shreeya shreeya.singh@students.iiit.ac.in


Here's what your changelog entry will look like:

🐛 Bug Fixes

@ttheshreeyasingh ttheshreeyasingh requested a review from a team as a code owner April 10, 2022 19:34
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why link_inline wasn't working? It looks like it's being used successfully in other places, so I'm not sure swapping it out is necessarily the right answer. Adding the mx_DesktopBuildsNotice isn't as this is the class for the another component.

Also I think you may need to merge develop to get the CI to pass.

I'm also going to make a minor change to the title so it's in the right tense for a change (this is what will appear in the changelog)

@dbkr dbkr changed the title 'your settings' in error message styled as link Style 'your settings' in error message as link Apr 11, 2022
@luixxiul
Copy link
Contributor

I guess there should be an issue of CSS style inheritance. Fixing it looks straightforward.

@kittykat
Copy link
Contributor

kittykat commented May 4, 2022

@ttheshreeyasingh I wanted to check in if you're intending to update your PR with the requested changes? If not, we'd like to unassign the issue in case anyone else would like to pick it up 👍

@MadLittleMods MadLittleMods added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Jun 1, 2022
@andybalaam
Copy link
Member

Abandoned - reopen if you are working on it.

@andybalaam andybalaam closed this Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants