This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Extract view/join room logic to room helper #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
previously requested changes
Apr 14, 2022
added 6 commits
April 19, 2022 09:56
Codecov Report
@@ Coverage Diff @@
## develop #8329 +/- ##
===========================================
- Coverage 30.03% 30.02% -0.01%
===========================================
Files 881 882 +1
Lines 50213 50226 +13
Branches 12791 12794 +3
===========================================
+ Hits 15081 15082 +1
- Misses 35132 35144 +12
|
turt2live
dismissed
their stale review
review was on an old diff, and may have been addressed
jryans
approved these changes
Apr 21, 2022
Comment on lines
+364
to
367
| Modal.createTrackedDialog(e.message, '', ErrorDialog, { | ||
| title: e.message, | ||
| description: e.description, | ||
| }); |
There was a problem hiding this comment.
Maybe utils/error.ts should offer this as showErrorModal()? I assume this could become a common pattern.
There was a problem hiding this comment.
I'm not sure we can do this as the .ts files should not have anything to do with UI according to our new style guide.
So i guess we should probably have some UI helpers?
germain-gg
added
the
T-Task
MadLittleMods
added a commit
that referenced
this pull request
Apr 3, 2023
Originally introduced in #8329 All usages were removed in #9605 This error also has problems with showing tranlsated versions in the logs. Part of element-hq/element-web#9597 We should be using the new `UserFriendlyError` for this kind of thing anyway. Introduced in #10440
3 tasks
MadLittleMods
added a commit
that referenced
this pull request
Apr 4, 2023
Originally introduced in #8329 All usages were removed in #9605 This error also has problems with showing tranlsated versions in the logs. Part of element-hq/element-web#9597 We should be using the new `UserFriendlyError` for this kind of thing anyway. Introduced in #10440
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for element-hq/element-web#21354, we need the logic extracted to helper function so that it can be re-used across the product
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8329--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.