This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add visual tests using Percy in Cypress #8610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
novocaine
reviewed
May 16, 2022
| for Safari, Firefox, Chrome & Edge, allowing us to spot visual regressions before they become release regressions. | ||
| Right now we run it as part of the standard Pull Request CI automation but due to only having 25k screenshots/month, | ||
| and each `cy.percySnapshot()` call results in 8 screenshots (4 browsers, 2 sizes) this could quickly be exhausted and | ||
| at that point we would likely run it on a CRON interval or before releases. |
There was a problem hiding this comment.
maybe we should wrap calls to percy in a flag that can be disabled so that we can separate out runs with percy? unless there's already a way?
There was a problem hiding this comment.
Percy will automatically no-op where Cypress is not ran from within percy, i.e percy exec -- - so for local testing cypress will behave the same as without percy, except with some extra log lines
In future we may additionally also create a label e.g X-Needs-Percy to control whether a PR needs to run the percy suite
novocaine
approved these changes
May 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is marked as an internal change (Task), so will not be included in the changelog.