Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[Release] Fix crash on null idp for SSO buttons #8653

Merged
merged 1 commit into from
May 20, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 20, 2022

#8650 to release


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • [Release] Fix crash on null idp for SSO buttons (#8653).

* Add test case for null identity_providers for SSO

* Fix typing for identity_providers

* Make null idp explicit and handle in analytics

* chore: whitespace fix

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
(cherry picked from commit 60cd740)
@t3chguy t3chguy added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label May 20, 2022
@t3chguy t3chguy requested a review from a team as a code owner May 20, 2022 09:10
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t3chguy t3chguy merged commit b66510a into release-v3.45.0 May 20, 2022
@t3chguy t3chguy deleted the t3chguy/cp/8650 branch May 20, 2022 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants