Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

cypress: log stdout/stderr when docker exec fails #9154

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Aug 9, 2022

Otherwise you cannot debug anything with errors like:

> Command failed: docker exec 134c9a0afd7dadd0b82ce69b4d72d3d6d8ca1b211540d4390a88357b68fa03b9 pg_isready -U postgres

Now we include the stdout/err prior to logging this.

element-web notes: none


This change is marked as an internal change (Task), so will not be included in the changelog.

Otherwise you cannot debug anything with errors like:
```
> Command failed: docker exec 134c9a0afd7dadd0b82ce69b4d72d3d6d8ca1b211540d4390a88357b68fa03b9 pg_isready -U postgres
```
Now we include the stdout/err prior to logging this.
@kegsay kegsay requested a review from a team as a code owner August 9, 2022 12:15
@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 9, 2022
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kegsay kegsay merged commit 147ec49 into develop Aug 9, 2022
@kegsay kegsay deleted the kegan/stdout-docker-exec branch August 9, 2022 14:22
kerryarchibald pushed a commit that referenced this pull request Aug 10, 2022
Otherwise you cannot debug anything with errors like:
```
> Command failed: docker exec 134c9a0afd7dadd0b82ce69b4d72d3d6d8ca1b211540d4390a88357b68fa03b9 pg_isready -U postgres
```
Now we include the stdout/err prior to logging this.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants