This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 831
Device manager - record device client information on app start (PSG-633) #9314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryarchibald
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Sep 23, 2022
kerryarchibald
force-pushed
the
psg-633/save-device-client-info
branch
from
September 23, 2022 16:00
01e2dc7
to
a37682e
Compare
3 tasks
turt2live
reviewed
Sep 23, 2022
}; | ||
|
||
export const getClientInformationEventType = (deviceId: string): string => | ||
`io.element.matrix-client-information.${deviceId}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a spec of some kind we can link to for this? Just a markdown document in element-meta or something should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering where this sort of documentation should live! Added here element-hq/element-meta#656
t3chguy
reviewed
Sep 27, 2022
turt2live
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh, sorry I forgot about this. Please feel free to start yelling if things take >1 business day to re-review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record information about the Matrix client and version on app startup, for display in new device manager
Designs:
Checklist
Notes: Device manager - record device client information on app start
This change is marked as an internal change (Task), so will not be included in the changelog.