Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Device manager - record device client information on app start (PSG-633) #9314

Merged
merged 8 commits into from
Oct 4, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Sep 23, 2022

Record information about the Matrix client and version on app startup, for display in new device manager

Screenshot 2022-09-27 at 16 28 43

Designs:
Screenshot 2022-09-23 at 17 14 28

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Device manager - record device client information on app start


This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 23, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner September 23, 2022 15:15
};

export const getClientInformationEventType = (deviceId: string): string =>
`io.element.matrix-client-information.${deviceId}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a spec of some kind we can link to for this? Just a markdown document in element-meta or something should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering where this sort of documentation should live! Added here element-hq/element-meta#656

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, sorry I forgot about this. Please feel free to start yelling if things take >1 business day to re-review.

@kerryarchibald kerryarchibald deleted the psg-633/save-device-client-info branch October 4, 2022 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants