Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Device manager - select all devices #9330

Merged
merged 8 commits into from
Oct 4, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Sep 29, 2022

Screen.Recording.2022-09-29.at.12.23.44.mov

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@kerryarchibald kerryarchibald requested a review from a team as a code owner September 29, 2022 10:25
@kerryarchibald kerryarchibald added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 29, 2022
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍
For some reason Cypress is angry with you...

@t3chguy
Copy link
Member

t3chguy commented Sep 30, 2022

Cypress is hosed until element-hq/element-web#23377 is fixed

@kerryarchibald kerryarchibald merged commit c59bbdf into develop Oct 4, 2022
@kerryarchibald kerryarchibald deleted the psg-659/device-man-select-all branch October 4, 2022 08:12
kerryarchibald pushed a commit that referenced this pull request Oct 4, 2022
* add device selection that does nothing

* multi select and sign out of sessions

* test multiple selection

* fix type after rebase

* select all sessions
odelcroi added a commit to tchapgouv/tchap-web-v4 that referenced this pull request Oct 5, 2022
* Device manager - select all devices ([\#9330](matrix-org/matrix-react-sdk#9330)). Contributed by @kerryarchibald.
* New group call experience: Call tiles ([\#9332](matrix-org/matrix-react-sdk#9332)).
* Add Shift key to FormatQuote keyboard shortcut ([\#9298](matrix-org/matrix-react-sdk#9298)). Contributed by @owi92.
* Device manager - sign out of multiple sessions ([\#9325](matrix-org/matrix-react-sdk#9325)). Contributed by @kerryarchibald.
* Display push toggle for web sessions (MSC3890) ([\#9327](matrix-org/matrix-react-sdk#9327)).
* Add device notifications enabled switch ([\#9324](matrix-org/matrix-react-sdk#9324)).
* Implement push notification toggle in device detail ([\#9308](matrix-org/matrix-react-sdk#9308)).
* New group call experience: Starting and ending calls ([\#9318](matrix-org/matrix-react-sdk#9318)).
* New group call experience: Room header call buttons ([\#9311](matrix-org/matrix-react-sdk#9311)).
* Make device ID copyable in device list ([\#9297](matrix-org/matrix-react-sdk#9297)). Contributed by @duxovni.
* Use display name instead of user ID when rendering power events ([\#9295](matrix-org/matrix-react-sdk#9295)).
* Read receipts for threads ([\#9239](matrix-org/matrix-react-sdk#9239)). Fixes #23191.
* Fix device selection in pre-join screen for Element Call video rooms ([\#9321](matrix-org/matrix-react-sdk#9321)). Fixes #23331.
* Don't render a 1px high room topic if the room topic is empty ([\#9317](matrix-org/matrix-react-sdk#9317)). Contributed by @Arnei.
* Don't show feedback prompts when that UIFeature is disabled ([\#9305](matrix-org/matrix-react-sdk#9305)). Fixes #23327.
* Fix soft crash around unknown room pills ([\#9301](matrix-org/matrix-react-sdk#9301)). Fixes matrix-org/element-web-rageshakes#15465.
* Fix spaces feedback prompt wrongly showing when feedback is disabled ([\#9302](matrix-org/matrix-react-sdk#9302)). Fixes #23314.
* Fix tile soft crash in ReplyInThreadButton ([\#9300](matrix-org/matrix-react-sdk#9300)). Fixes matrix-org/element-web-rageshakes#15493.
kerryarchibald pushed a commit that referenced this pull request Oct 5, 2022
* record device client inforamtion events on app start

* matrix-client-information -> matrix_client_information

* fix types

* remove another unused export

* add docs link

* display device client information in device details

* update snapshots

* integration-ish test client information in metadata

* tests

* fix tests

* export helper

* DeviceClientInformation type

* Device manager - select all devices (#9330)

* add device selection that does nothing

* multi select and sign out of sessions

* test multiple selection

* fix type after rebase

* select all sessions

* rename type

* use ExtendedDevice type everywhere

* rename clientName to appName for less collision with UA parser

* fix bad find and replace

* rename ExtendedDeviceInfo to ExtendedDeviceAppInfo

* rename DeviceType comp to DeviceTypeIcon

* update tests for new required property deviceType

* add stubbed user agent parsing
kerryarchibald pushed a commit that referenced this pull request Oct 6, 2022
* record device client inforamtion events on app start

* matrix-client-information -> matrix_client_information

* fix types

* remove another unused export

* add docs link

* display device client information in device details

* update snapshots

* integration-ish test client information in metadata

* tests

* fix tests

* export helper

* DeviceClientInformation type

* Device manager - select all devices (#9330)

* add device selection that does nothing

* multi select and sign out of sessions

* test multiple selection

* fix type after rebase

* select all sessions

* rename type

* use ExtendedDevice type everywhere

* rename clientName to appName for less collision with UA parser

* fix bad find and replace

* rename ExtendedDeviceInfo to ExtendedDeviceAppInfo

* rename DeviceType comp to DeviceTypeIcon

* update tests for new required property deviceType

* add stubbed user agent parsing

* setup test cases

* detect device type correctly

* 80% working ua parser

* parse asera gents for device info

* combine clientName/Version into one field, remove debug from tests
kerryarchibald pushed a commit that referenced this pull request Oct 6, 2022
* record device client inforamtion events on app start

* matrix-client-information -> matrix_client_information

* fix types

* remove another unused export

* add docs link

* display device client information in device details

* update snapshots

* integration-ish test client information in metadata

* tests

* fix tests

* export helper

* DeviceClientInformation type

* Device manager - select all devices (#9330)

* add device selection that does nothing

* multi select and sign out of sessions

* test multiple selection

* fix type after rebase

* select all sessions

* rename type

* use ExtendedDevice type everywhere

* rename clientName to appName for less collision with UA parser

* fix bad find and replace

* rename ExtendedDeviceInfo to ExtendedDeviceAppInfo

* rename DeviceType comp to DeviceTypeIcon

* update tests for new required property deviceType

* add stubbed user agent parsing

* add icons

* set device type icon

* device type icon tets

* update snapshots for device type icon changes

* desktop icon viewbox

* i18n
weeman1337 pushed a commit that referenced this pull request Oct 7, 2022
* record device client inforamtion events on app start

* matrix-client-information -> matrix_client_information

* fix types

* remove another unused export

* add docs link

* display device client information in device details

* update snapshots

* integration-ish test client information in metadata

* tests

* fix tests

* export helper

* DeviceClientInformation type

* Device manager - select all devices (#9330)

* add device selection that does nothing

* multi select and sign out of sessions

* test multiple selection

* fix type after rebase

* select all sessions

* rename type

* use ExtendedDevice type everywhere

* rename clientName to appName for less collision with UA parser

* fix bad find and replace

* rename ExtendedDeviceInfo to ExtendedDeviceAppInfo

* rename DeviceType comp to DeviceTypeIcon

* update tests for new required property deviceType

* add stubbed user agent parsing

* add icons

* set device type icon

* device type icon tets

* update snapshots for device type icon changes

* desktop icon viewbox

* i18n
kerryarchibald pushed a commit that referenced this pull request Oct 7, 2022
* record device client inforamtion events on app start

* matrix-client-information -> matrix_client_information

* fix types

* remove another unused export

* add docs link

* display device client information in device details

* update snapshots

* integration-ish test client information in metadata

* tests

* fix tests

* export helper

* DeviceClientInformation type

* Device manager - select all devices (#9330)

* add device selection that does nothing

* multi select and sign out of sessions

* test multiple selection

* fix type after rebase

* select all sessions

* rename type

* use ExtendedDevice type everywhere

* rename clientName to appName for less collision with UA parser

* fix bad find and replace

* rename ExtendedDeviceInfo to ExtendedDeviceAppInfo

* rename DeviceType comp to DeviceTypeIcon

* update tests for new required property deviceType

* add stubbed user agent parsing

* setup test cases

* detect device type correctly

* 80% working ua parser

* parse asera gents for device info

* combine clientName/Version into one field, remove debug from tests

* add new metadata to device details

* render device info from UA
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants