Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Change ListNotificationState to store room ids #9518

Commits on Oct 28, 2022

  1. Changed ListNotificationState to store room ids

    ListNotificationState stores a reference to a rooms array which is later
    used for comparing the stored array with new arrays. However, the
    comparison may fail since the stored array can be changed outside the
    class. This PR proposes to instead store only the room ids, which
    hopefully allows to avoid the issue by copying the room ids into
    a new array, while still being performant.
    
    Signed-off-by: Arne Wilken arnepokemon@yahoo.de
    Arnei committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    8e94efb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d76ed37 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Change ListNotificationState to shallow clone rooms

    Instead of using room ids like in the previous commit,
    shallow clone the rooms array instead.
    Arnei committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8737a20 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/fix-unread-notifications-remaini…

    …ng-after-deleting-room' into fix-unread-notifications-remaining-after-deleting-room
    Arnei committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    37ec967 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4bb3f8c View commit details
    Browse the repository at this point in the history