Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Stop voice broadcast on delete #9629

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Stop voice broadcast on delete #9629

merged 1 commit into from
Nov 28, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Nov 28, 2022 •
edited
Loading

Part of element-hq/element-web#23282

PSF-1674

rm

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 28, 2022
@weeman1337 weeman1337 marked this pull request as ready for review November 28, 2022 13:34
@weeman1337 weeman1337 requested a review from a team as a code owner November 28, 2022 13:34
robintown
robintown approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weeman1337 weeman1337 merged commit 3c7781a into develop Nov 28, 2022
@weeman1337 weeman1337 deleted the weeman1337/stop-voice-broadcast-on-delete branch November 28, 2022 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robintown robintown robintown approved these changes

@artcodespace artcodespace Awaiting requested review from artcodespace artcodespace is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @robintown