Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

[iOS] Improved text view injection #935

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 8, 2024

  • A default text view is always provided, to allow for easier testing and avoid using an optional, even if you should always inject it from the UI wrapper
  • The initialisation is done directly by a convenience init from the text view itself
  • the MentionsDisplayHelper is now managed by the viewModel which will refresh it on the textView

where the text view is never nil, but can still be injected to simplify tests and allow the mention display helper to be initialised before the appearance of the view
@Velin92 Velin92 added the iOS label Feb 8, 2024
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (2f40a21) 89.96% compared to head (41f0075) 88.23%.

Files Patch % Lines
...WysiwygComposerView/WysiwygComposerViewModel.swift 59.25% 10 Missing and 1 partial ⚠️
...ents/WysiwygComposerView/WysiwygComposerView.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   89.96%   88.23%   -1.74%     
==========================================
  Files          32      118      +86     
  Lines        1565    16935   +15370     
  Branches      623      616       -7     
==========================================
+ Hits         1408    14942   +13534     
- Misses        132     1964    +1832     
- Partials       25       29       +4     
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 88.23% <67.50%> (+13.15%) ⬆️
unittests-ios 75.70% <67.50%> (+0.62%) ⬆️
unittests-rust 89.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Velin92 Velin92 merged commit 0fc359b into main Feb 8, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/better_text_view_architecture branch February 8, 2024 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants