Create workaround flow and release script #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be removed when the x86_64 issue is solved.
jmartinesp
commented
Apr 17, 2023
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@nightly | ||
| with: | ||
| toolchain: 1.67.0 |
There was a problem hiding this comment.
Maybe we could use 1.68 here, but I'm not sure and testing it is quite time consuming.
|
|
||
| - name: Install cargo-ndk | ||
| continue-on-error: true | ||
| run: cargo install cargo-ndk --version 2.11.0 --force # needed to use a previous version of cargo-ndk |
There was a problem hiding this comment.
Here we might be able to use versions up to 2.12.2 if I'm not mistaken, but again, testing is time consuming and this version seems to work fine.
| @@ -22,7 +22,7 @@ android { | |||
|
|
|||
| minSdk ConfigurationData.minSdk | |||
| targetSdk ConfigurationData.targetSdk | |||
| versionName ConfigurationData.versionNameCrypto | |||
| versionName ConfigurationData.versionNameSdk | |||
There was a problem hiding this comment.
I think there was a copy&paste typo issue here.
Comment on lines
+259
to
+262
| # Call the build script in debug mode first to workaround a bug in cargo-ndk | ||
| execute_build_script(current_dir, sdk_path, args.module, False) | ||
| # Then use the proper release mode one | ||
| execute_build_script(current_dir, sdk_path, args.module, True) |
There was a problem hiding this comment.
The release script clones the SDK repo, so I had to add the 'build debug, then release' workaround here and duplicate the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When releasing v0.1.7 we found there was an issue with x86_64 binaries which instantly crashed the app on startup. While this seems to be a Rust compiler issue, I also opened an issue in the cargo-ndk repo in case we can find a better workaround, as the team in Mozilla did here.
For now it seems like we'd have to roll back to a previous version of the NDK and cargo-ndk (and because of this, a previous rustc version too if I'm not mistaken). This old cargo-ndk version also has the issue that building only the release version will fail, so we need to build the library twice, first with the dev profile and then the release one.
Also, I'd have to test it, but I think we might not need to use the
macos-latestrunner for these, and that should improve build times a fair bit.