-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: use plain synapse
docker images for testing
#3340
Comments
If we use the synapse docker image, and it's easy to enable experimental features (which is how I started looking into this), we should reenable the test disabled with the last commit of #3339. |
Unless things have changed with Synapse images, it will be much less ergonomic to use the official images which is why Neither the official image nor the complement image make it easy to enable experimental MSCs sadly. The enabled set of MSCs in the Complement Synapse image is hard-coded at https://github.com/element-hq/synapse/blob/develop/docker/complement/conf/workers-shared-extra.yaml.j2#L106 I suspect the "best" solution here would be to pester me / someone from backend to improve the Synapse Complement image to:
And then you can just use the Synapse Complement image as a drop-in replacement. The env vars in that image exactly match the ones in synapse-service. |
This is an alternative to matrix-org/matrix-rust-sdk#3340 where we don't need to change our CI setup too much in the Rust SDK repository, and still can test MSC3266.
Both integration testing + code coverage use an image labelled
synapse-service
, which is likely outdated (points to thematrix-org
org) and hard to find. We should likely use the regular synapse Docker image for testing, if we could.The text was updated successfully, but these errors were encountered: