Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use plain synapse docker images for testing #3340

Closed
bnjbvr opened this issue Apr 18, 2024 · 2 comments · Fixed by #3404
Closed

CI: use plain synapse docker images for testing #3340

bnjbvr opened this issue Apr 18, 2024 · 2 comments · Fixed by #3404

Comments

@bnjbvr
Copy link
Member

bnjbvr commented Apr 18, 2024

Both integration testing + code coverage use an image labelled synapse-service, which is likely outdated (points to the matrix-org org) and hard to find. We should likely use the regular synapse Docker image for testing, if we could.

@bnjbvr
Copy link
Member Author

bnjbvr commented Apr 18, 2024

If we use the synapse docker image, and it's easy to enable experimental features (which is how I started looking into this), we should reenable the test disabled with the last commit of #3339.

@kegsay
Copy link
Member

kegsay commented Apr 19, 2024

Unless things have changed with Synapse images, it will be much less ergonomic to use the official images which is why synapse-service exists. It's less ergonomic because you can't just configure everything with env vars (like you can with say the postgres docker image which is trivial to use as a GHA service) and will need to faff about with the YAML config file and generating server keys.

Neither the official image nor the complement image make it easy to enable experimental MSCs sadly. The enabled set of MSCs in the Complement Synapse image is hard-coded at https://github.com/element-hq/synapse/blob/develop/docker/complement/conf/workers-shared-extra.yaml.j2#L106

I suspect the "best" solution here would be to pester me / someone from backend to improve the Synapse Complement image to:

  • not crash if you don't give it a CA certs directory (this is why I made synapse-service in the first place)
  • make it possible to enable MSCs via env vars.

And then you can just use the Synapse Complement image as a drop-in replacement. The env vars in that image exactly match the ones in synapse-service.

kegsay pushed a commit to element-hq/synapse that referenced this issue May 2, 2024
This is an alternative to
matrix-org/matrix-rust-sdk#3340 where we don't
need to change our CI setup too much in the Rust SDK repository, and
still can test MSC3266.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants