Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UniFFI proc-macros for constructors #1830

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Apr 26, 2023

@jplatte jplatte force-pushed the jplatte/uniffi-object-ctors branch from 684c4cc to 0ede834 Compare April 27, 2023 11:36
@jplatte jplatte marked this pull request as ready for review April 27, 2023 11:37
@jplatte jplatte closed this Apr 27, 2023
@jplatte jplatte reopened this Apr 27, 2023
@jplatte jplatte requested a review from Hywan April 27, 2023 11:39
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bafcf23) 76.43% compared to head (5d040d1) 76.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1830   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files         140      140           
  Lines       15970    15970           
=======================================
  Hits        12207    12207           
  Misses       3763     3763           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jplatte jplatte force-pushed the jplatte/uniffi-object-ctors branch from 0ede834 to e2f1302 Compare April 27, 2023 12:39
@jplatte jplatte force-pushed the jplatte/uniffi-object-ctors branch from 6307f6c to 5d040d1 Compare April 28, 2023 08:02
@jplatte jplatte requested a review from a team April 28, 2023 08:03
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jplatte jplatte merged commit b4faef7 into main Apr 28, 2023
@jplatte jplatte deleted the jplatte/uniffi-object-ctors branch April 28, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants