appservice: Add client_with_config singleton #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannescpk
force-pushed
the
feat/appservice-client-config
branch
from
de853ef
to
7f47cc7
Compare
40 tasks
poljar
requested changes
May 25, 2021
johannescpk
force-pushed
the
feat/appservice-client-config
branch
from
7f47cc7
to
8053480
Compare
johannescpk
commented
May 25, 2021
johannescpk
force-pushed
the
feat/appservice-client-config
branch
2 times, most recently
from
d04e944
to
4b6b1b0
Compare
johannescpk
commented
May 26, 2021
Comment on lines
+183
to
+185
| /// Dummy type for shared documentation | ||
| #[allow(dead_code)] | ||
| pub type MainAppserviceUser = (); |
There was a problem hiding this comment.
I wonder whether there's a more elegant way for rust docs glossaries 🤔
There was a problem hiding this comment.
Well, could probably work with simply a doc-only module and linking there
There was a problem hiding this comment.
Yeah I have been planing to do a matrix-sdk tutorial module for a while, though haven't managed to get around to it yet.
johannescpk
force-pushed
the
feat/appservice-client-config
branch
from
4b6b1b0
to
1372b6a
Compare
poljar
requested changes
May 31, 2021
matrix_sdk_appservice/src/lib.rs
Outdated
| /// Since this method is a singleton follow-up calls with different | ||
| /// [`ClientConfig`]s will be ignored. | ||
| pub async fn client_with_config( | ||
| &mut self, |
There was a problem hiding this comment.
Is that &mut still needed? I don't think you need it since the clients are in the dashmap.
There was a problem hiding this comment.
Good catch, isn't needed anymore indeed
I wonder what it takes to teach clippy about DashMap 🤔
johannescpk
force-pushed
the
feat/appservice-client-config
branch
from
1372b6a
to
1df6d18
Compare
johannescpk
force-pushed
the
feat/appservice-client-config
branch
from
1df6d18
to
3f2fecd
Compare
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new_with_client_configto allow configuring main appservice user clientclient_with_configto allow configuring virtual user clientsget_request_configon theClientAppservice'sclientmethod to be a singleton that caches clients internallyAppserviceRegistrationinto anArcclientmethod singleton: Since in an appservice context clients get often constructed on demand it could lead to easy footguns in terms of having multiple clients trying to sync, which is especially problematic in terms of E2EEPart of #228