Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove matrix-sdk-appservice #2509

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Remove matrix-sdk-appservice #2509

merged 2 commits into from
Sep 5, 2023

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Sep 5, 2023

There is unfortunately no capacity for maintaining it as a first-party component of the Rust SDK.

There is unfortunately no capacity for maintaining it as a first-party
component of the Rust SDK.
@jplatte jplatte requested a review from a team as a code owner September 5, 2023 13:13
@jplatte jplatte requested review from poljar and removed request for a team September 5, 2023 13:13
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.11% 🎉

Comparison is base (11b3be1) 77.32% compared to head (947f89c) 77.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
+ Coverage   77.32%   77.44%   +0.11%     
==========================================
  Files         184      178       -6     
  Lines       19545    19225     -320     
==========================================
- Hits        15113    14888     -225     
+ Misses       4432     4337      -95     
Files Changed Coverage Δ
crates/matrix-sdk/src/client/builder.rs 77.68% <ø> (-1.39%) ⬇️
crates/matrix-sdk/src/client/mod.rs 75.68% <ø> (-1.13%) ⬇️
crates/matrix-sdk/src/config/request.rs 100.00% <ø> (ø)
crates/matrix-sdk/src/http_client/mod.rs 78.12% <81.81%> (+3.12%) ⬆️
crates/matrix-sdk/src/matrix_auth/mod.rs 87.96% <100.00%> (-0.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jplatte jplatte merged commit 2d47aec into main Sep 5, 2023
@jplatte jplatte deleted the jplatte/rm-appservice branch September 5, 2023 13:40
@caldwell
Copy link

Oh bummer, I was just trying this out for the last few weeks with decent results (I understand not having the bandwidth to maintain it though). Are there any plans to move it to a separate repo or something like that?

@Hywan
Copy link
Member

Hywan commented Sep 20, 2023

We don't have plan to extract it into its own repo. Nonetheless, I bet it should be OK for you to extract it and create your own fork though?

@jplatte
Copy link
Collaborator Author

jplatte commented Sep 20, 2023

Well, the appservice crate was relying on some functionality from the main SDK crate that was also removed. To anybody who wants to start a new appservice crate (some of the old code could certainly be reused), I recommend coming to #matrix-rust-sdk-dev to discuss that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants