-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove matrix-sdk-appservice #2509
Conversation
There is unfortunately no capacity for maintaining it as a first-party component of the Rust SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2509 +/- ##
==========================================
+ Coverage 77.32% 77.44% +0.11%
==========================================
Files 184 178 -6
Lines 19545 19225 -320
==========================================
- Hits 15113 14888 -225
+ Misses 4432 4337 -95
☔ View full report in Codecov by Sentry. |
Oh bummer, I was just trying this out for the last few weeks with decent results (I understand not having the bandwidth to maintain it though). Are there any plans to move it to a separate repo or something like that? |
We don't have plan to extract it into its own repo. Nonetheless, I bet it should be OK for you to extract it and create your own fork though? |
Well, the appservice crate was relying on some functionality from the main SDK crate that was also removed. To anybody who wants to start a new appservice crate (some of the old code could certainly be reused), I recommend coming to #matrix-rust-sdk-dev to discuss that. |
There is unfortunately no capacity for maintaining it as a first-party component of the Rust SDK.