Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret storage support #2591

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Secret storage support #2591

merged 2 commits into from
Oct 10, 2023

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Sep 20, 2023 •
edited by dkasak
Loading

Initial support for secret storage in the matrix-sdk-crypto crate.

This is the crypto crate part of: #402

The main crate PR is at #2621.

  • Public API changes documented in changelogs (optional)

@poljar poljar requested a review from a team as a code owner September 20, 2023 12:29
@poljar poljar requested review from jplatte and dkasak and removed request for a team September 20, 2023 12:29
@poljar poljar self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (63fab7e) 78.30% compared to head (9aaba44) 78.41%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2591      +/-   ##
==========================================
+ Coverage   78.30%   78.41%   +0.10%     
==========================================
  Files         191      192       +1     
  Lines       19952    20098     +146     
==========================================
+ Hits        15624    15760     +136     
- Misses       4328     4338      +10
Files Coverage Δ
crates/matrix-sdk-crypto/src/ciphers.rs 100.00% <100.00%> (ø)
crates/matrix-sdk-crypto/src/lib.rs 100.00% <ø> (ø)
crates/matrix-sdk-crypto/src/secret_storage.rs 92.42% <92.42%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar mentioned this pull request Sep 20, 2023
Closed
@poljar poljar force-pushed the poljar/svuda-seremo-samo-slaninu branch from f423b62 to 2aef91c Compare September 20, 2023 14:54
@jplatte jplatte requested review from Hywan and removed request for jplatte September 21, 2023 08:42
Hywan
Hywan reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks excellent, well done!

crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
@poljar poljar force-pushed the poljar/svuda-seremo-samo-slaninu branch from b2f1767 to cda9ed1 Compare September 26, 2023 10:43
@poljar poljar mentioned this pull request Sep 26, 2023
Merged
1 task
@poljar poljar force-pushed the poljar/svuda-seremo-samo-slaninu branch from cda9ed1 to ae5b3a2 Compare October 3, 2023 11:25
dkasak
dkasak approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@dkasak dkasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor suggestions (mostly regarding comment wording), this looks very good! Especially the exhaustive test suite. ❤️

crates/matrix-sdk-crypto/src/ciphers.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/ciphers.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/ciphers.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/ciphers.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/ciphers.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/secret_storage.rs Outdated Show resolved Hide resolved
poljar and others added 2 commits October 10, 2023 17:37
@poljar @Hywan @dkasak
Secret storage support
78e4e81 
Co-authored-by: Ivan Enderlin <ivan@mnt.io>
Co-authored-by: Denis Kasak <dkasak@termina.org.uk>
@poljar
Rename the encrypt_with_iv method so it's clear that it also can de…
9aaba44 
…crypt
@poljar poljar force-pushed the poljar/svuda-seremo-samo-slaninu branch from e351222 to 9aaba44 Compare October 10, 2023 15:43
@poljar poljar enabled auto-merge (rebase) October 10, 2023 15:54
@poljar poljar merged commit c2bb760 into main Oct 10, 2023
36 checks passed
@poljar poljar deleted the poljar/svuda-seremo-samo-slaninu branch October 10, 2023 16:15
richvdh added a commit that referenced this pull request Nov 9, 2023
@richvdh
Update changelog for matrix-sdk-crypto
b8557e2 
 - Add an entry which I forgot for #2805

 - Reorder a few other items that have been added since
 #2591.
@richvdh richvdh mentioned this pull request Nov 9, 2023
Merged
richvdh added a commit that referenced this pull request Nov 10, 2023
@richvdh
Update changelog for matrix-sdk-crypto (#2837)
5786b1a 
- Add an entry which I forgot for #2805

 - Reorder a few other items that have been added since
 #2591.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

@dkasak dkasak dkasak approved these changes

Assignees

@poljar poljar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poljar @dkasak @Hywan