-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appservice: Exclude from coverage CI for now #265
appservice: Exclude from coverage CI for now #265
Conversation
ffac935
to
e33bdb9
Compare
e33bdb9
to
248078e
Compare
Wouldn't disabling the failing test when the app service feature is enabled get us most of the way there? diff --git a/matrix_sdk/src/client.rs b/matrix_sdk/src/client.rs
index 47227b473..41d073cb9 100644
--- a/matrix_sdk/src/client.rs
+++ b/matrix_sdk/src/client.rs
@@ -2706,7 +2706,6 @@ mod test {
client::{
self as client_api,
r0::{
- account::register::{RegistrationKind, Request as RegistrationRequest},
directory::{
get_public_rooms,
get_public_rooms_filtered::{self, Request as PublicRoomsFilterRequest},
@@ -2714,7 +2713,7 @@ mod test {
media::get_content_thumbnail::Method,
membership::Invite3pidInit,
session::get_login_types::LoginType,
- uiaa::{AuthData, UiaaResponse},
+ uiaa::AuthData,
},
},
error::{FromHttpResponseError, ServerError},
@@ -3042,7 +3041,13 @@ mod test {
}
#[tokio::test]
+ #[cfg(not(feature = "appservice"))]
async fn register_error() {
+ use ruma::api::client::r0::{
+ account::register::{RegistrationKind, Request as RegistrationRequest},
+ uiaa::UiaaResponse
+ };
+
let homeserver = Url::from_str(&mockito::server_url()).unwrap();
let client = Client::new(homeserver).unwrap(); |
While we could do that I'd say we want to avoid having the |
Like, already now, all tests going through the |
Yeah that's true, but that does mean that Perhaps we'll need to modify the feature to only enable the ability to become an app service but people would need to configure the |
I see, the issue also being dev experience where you can't just run Deciding app service functionality at runtime feels less clean, but it'd indeed unlock having both in one project, which might not only be nice to have - but should also prevent things from failing unexpectedly, which currently could happen if both approaches are mixed in one project. I'll look into that. 👍 |
Part of #228