Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc secret storage fixes #2757

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Misc secret storage fixes #2757

merged 2 commits into from
Oct 23, 2023

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Oct 20, 2023

These two commits are part of #2621, I'm pulling them out to get at least some parts of that PR merged.

@poljar poljar requested a review from a team as a code owner October 20, 2023 15:42
@poljar poljar requested review from bnjbvr and removed request for a team October 20, 2023 15:42
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71627a2) 78.78% compared to head (2366164) 78.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2757      +/-   ##
==========================================
- Coverage   78.78%   78.77%   -0.01%     
==========================================
  Files         204      204              
  Lines       20736    20736              
==========================================
- Hits        16337    16335       -2     
- Misses       4399     4401       +2     
Files Coverage Δ
crates/matrix-sdk-crypto/src/secret_storage.rs 90.90% <100.00%> (-1.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging for the sake of expediency, but would be super nice to add some regression tests when you're back, if possible, since it's absolutely not clear what this fixes.

@bnjbvr bnjbvr merged commit 7440ce0 into main Oct 23, 2023
@bnjbvr bnjbvr deleted the poljar/misc-secret-storage-fixes branch October 23, 2023 08:24
@poljar
Copy link
Contributor Author

poljar commented Oct 23, 2023

Approving and merging for the sake of expediency, but would be super nice to add some regression tests when you're back, if possible, since it's absolutely not clear what this fixes.

Well I hope that a forgotten re-export is sufficiently clear. The other commit changes the event_type() method to use a Ruma type instead of a string. The event_type() method is already tested as you can see I had to change the test as well.

@bnjbvr
Copy link
Member

bnjbvr commented Oct 23, 2023

I completely failed to see the second part was changing tests, my bad (and thanks!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants