Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appservice: Drop actix #290

Merged
merged 1 commit into from
Jun 29, 2021
Merged

appservice: Drop actix #290

merged 1 commit into from
Jun 29, 2021

Conversation

johannescpk
Copy link
Contributor

@johannescpk johannescpk commented Jun 29, 2021 •
edited
Loading

Reasoning

  • Generally I'd be open to keep supporting actix, but in the current state of the appservice crate it doesn't make sense to actively support two webservers
  • also actix-web
    • isn't really multi-threaded nor Send + Sync
    • does specialized non-standard usage of the tokio runtime
    • often relies on non-idiomatic paradigms and heavily utilizes unsafe
  • (and unbreaks CI right now)

Part of #228

@johannescpk johannescpk mentioned this pull request Jun 29, 2021
Closed
@johannescpk johannescpk mentioned this pull request Jun 29, 2021
Closed
40 tasks
@poljar poljar merged commit f454d40 into matrix-org:master Jun 29, 2021
@poljar
Copy link
Contributor

poljar commented Jun 29, 2021

Thanks for handling this, merged.

@johannescpk johannescpk deleted the appservice/drop/actix branch June 29, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannescpk @poljar