Add custom storage #315
Merged
Add custom storage #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional tree to the Store where custom api consumer data may be stored.
poljar
requested changes
Sep 8, 2021
matrix_sdk/src/client.rs
Outdated
| @@ -828,6 +828,16 @@ impl Client { | |||
| self.base_client.store() | |||
| } | |||
|
|
|||
| /// Store a value in the custom tree on the store | |||
| pub async fn store_save_value(&self, key: &[u8], value: Vec<u8>) -> Result<Option<Vec<u8>>> { | |||
There was a problem hiding this comment.
As you noticed, you can get the Store from the client, so these methods are a bit redundant. I would say let's try to keep the Client slim, it is a bit an impossible task to do so considering the API surface of Matrix but removing this certainly would help with that.
|
Made the necessary changes myself. Thanks, merged. |
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #271.
Add an additional tree to the Store where custom api consumer data may
be stored.
I'm not sure exactly what types are the smartest to use for the keys and values here. While it would be nice to be able to use sled-types as suggested by the issue, it would make the custom store implementation dependent. I'm also not sure if the method on
Clientis necessary when the custom store can be interacted with via getting a reference to theStore.