ci: Split codecov uploads into a separate workflow #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which runs in the context of the main repo even for PRs, and can be retried individually without rerunning coverage collection.
|
Hm, new workflow file doesn't trigger, prob. will only start doing that after it's part of |
|
I'm curious as to why it didn't trigger in this branch; shouldn't it? I'm pretty sure I've seen in the past that new CI steps would run in the PR that introduced them… |
bnjbvr
requested review from
a team and
Hywan
and removed request for
bnjbvr and
a team
bnjbvr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… which runs in the context of the main repo even for PRs from forks, and can be retried individually without rerunning coverage collection.
I saw you're still suffering from codecov's problems, so I decided to take the time required to look up the most recent suggested workaround (most up-to-date upstream issue discussing this stuff is codecov/feedback#301 and contains links to the workflows I copied here).
Hope it works. If not, maybe you can get it to work. Can't promise that I'll put more time into this.