-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to log in using a QR code #3466
Conversation
79b1b95
to
813a9b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! Congrats for the quality of the code and the commits, thank you.
I've left a couple of feedback, but nothing too difficult to fix.
crates/matrix-sdk/src/authentication/qrcode/rendezvous_channel.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk/src/authentication/qrcode/rendezvous_channel.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk/src/authentication/qrcode/rendezvous_channel.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback!
crates/matrix-sdk/src/authentication/qrcode/rendezvous_channel.rs
Outdated
Show resolved
Hide resolved
No no, thanks for the swift review. |
008a33d
to
aa59aeb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3466 +/- ##
==========================================
+ Coverage 83.28% 83.65% +0.36%
==========================================
Files 248 254 +6
Lines 25272 25592 +320
==========================================
+ Hits 21049 21408 +359
+ Misses 4223 4184 -39 ☔ View full report in Codecov by Sentry. |
536b097
to
10b0de7
Compare
This implements one part of MSC4108[1], it implements the case where the new device scans the QR code. [1]: matrix-org/matrix-spec-proposals#4108
10b0de7
to
4d8bfbd
Compare
This implements part of MSC4108. We're only supporting the case where new device scans the QR code and gets logged in by the existing device.
Opening as a draft as I want to reword the commit messages a bit, add some more documentation (mainly to insert some jokes about rendezvous), and possibly one or two more tests.
Best reviewed commit by commit, although there is one giant commit. Reviewer please have mercy on me.