Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: Add Python bindings UniFFI config #3929

Closed
wants to merge 1 commit into from

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Sep 2, 2024

Those changes allow to build functional Python wheel of the crypto FFI layer using maturin.
Something is still not right for the full SDK FFI, I am looking into it but it should be a change on maturin side.

Currently depends on a change in maturin.

  • Public API changes documented in changelogs (optional)

Signed-off-by: Mathieu Velten mathieu@velten.xyz

@MatMaul MatMaul requested a review from a team as a code owner September 2, 2024 20:23
@MatMaul MatMaul requested review from jmartinesp and removed request for a team September 2, 2024 20:23
@Hywan
Copy link
Member

Hywan commented Sep 3, 2024

Hello and thanks for your contribution.

While I acknowledge it can be useful to support Python, we don't want to support it here as it means we will also be responsible to publish wheels/packages to pypi etc., which we won't.

I'm sorry but we don't want to provide official Python support for the moment.

@MatMaul
Copy link
Contributor Author

MatMaul commented Sep 3, 2024

I understand you don't want too much support burden and I am not asking to provide official support or wheels, but can we still work on basic support like this PR ? By adding an explicit disclaimer (no official support, no build, experimental) in the README for example.

FYI I am trying to solve libolm deprecation for the content scanner.

@bnjbvr bnjbvr changed the title Add Python bindings UniFFI config ffi: Add Python bindings UniFFI config Sep 3, 2024
@poljar
Copy link
Contributor

poljar commented Sep 4, 2024

I understand you don't want too much support burden and I am not asking to provide official support or wheels, but can we still work on basic support like this PR ? By adding an explicit disclaimer (no official support, no build, experimental) in the README for example.

FYI I am trying to solve libolm deprecation for the content scanner.

Since our conversation over at element-hq/matrix-content-scanner-python#64, can this be closed?

I would be fine with some of these changes, if they don't hurt the Kotlin/Swift bindings, but including the pyproject.toml file really seems wrong since we don't intend on publishing this to PyPi.

On the other hand, if you don't need this, let's close it.

@MatMaul
Copy link
Contributor Author

MatMaul commented Sep 4, 2024

Let's close for now, thanks for the feedback.

@MatMaul MatMaul closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants