-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindings: Expose the PkEncryption stuff in the crypto crate bindings #3971
Conversation
@poljar I've got an issue when building this branch, not sure this is related to your change. The command: ./scripts/build.sh -p ../matrix-rust-sdk -m crypto -t aarch64-linux-android (from the project https://github.com/matrix-org/matrix-rust-components-kotlin) and the error:
any ideas? |
Seems like I can't return |
@bmarty should work now, I changed the offending function to return an error instead. |
Thanks, it's now compiling. |
3210d48
to
3b2664b
Compare
OK, the code change is in this commit, you may want to double check: element-hq/element-android@355621b |
3655c69
to
506a449
Compare
3b2664b
to
6905ed2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3971 +/- ##
=======================================
Coverage 84.28% 84.28%
=======================================
Files 266 266
Lines 28286 28286
=======================================
Hits 23840 23840
Misses 4446 4446 ☔ View full report in Codecov by Sentry. |
6905ed2
to
22ac2e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there is a small typo in case you want to fix it.
Again a draft until we get things merged in vodozemac land.
@bmarty and @Velin92 I think this is all you need for the legacy apps. Please shout if there's more needed.