feat(send queue): allow editing media captions #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4277 +/- ##
==========================================
- Coverage 85.04% 84.97% -0.07%
==========================================
Files 274 274
Lines 30043 30230 +187
==========================================
+ Hits 25550 25689 +139
- Misses 4493 4541 +48 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
… to `mark_dependent_queued_requests_as_ready`
bnjbvr
force-pushed
the
bnjbvr/edit-captions
branch
from
017431e to
f070236
Compare
stefanceriu
reviewed
Nov 19, 2024
…t yet test(timeline): add an integration test for sending an attachment test(timeline): add tests for multiple caption edits and local reaction to a media upload
bnjbvr
force-pushed
the
bnjbvr/edit-captions
branch
from
d16775c to
ddacf1b
Compare
stefanceriu
approved these changes
Nov 19, 2024
| let event_id = event_id!("$1"); | ||
| let own_user_id = user_id!("@me:saucisse.bzh"); | ||
|
|
||
| let filename = "rickroll.gif"; |
Comment on lines
+619
to
+621
| let QueuedRequestKind::Event { content: serialized_content } = found.kind else { | ||
| return Err(InvalidMediaCaptionEdit); | ||
| }; |
There was a problem hiding this comment.
Just for my understanding: finding a non-event kind here is a developer error and the wrong txn was passed in, right?
There was a problem hiding this comment.
Indeed, all these errors would either be caused by a wrong txn_id, or a super inconsistent internal state 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows editing media captions:
make_edit_eventis sufficient,Fixes #4201