fix(room_preview): add fallback server names when possible #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
approved these changes
Nov 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4357 +/- ##
=======================================
Coverage 85.10% 85.10%
=======================================
Files 280 280
Lines 30535 30543 +8
=======================================
+ Hits 25988 25995 +7
- Misses 4547 4548 +1 ☔ View full report in Codecov by Sentry. |
jmartinesp
force-pushed
the
fix/include-server-name-automatically-for-room-preview
branch
from
bf2888e to
0028c93
Compare
…r names If no server names are provided for the room summary request and the room's server name doesn't match the current user's server name, add the room alias/id server name as a fallback value. This seems to fix room preview through federation. Also, when getting a summary for a room list item, if it's an invite one, add the server name of the inviter's user id as another possible fallback. Changelog: Use the inviter's server name and the server name from the room alias as fallback values for the via parameter when requesting the room summary from the homeserver.
poljar
force-pushed
the
fix/include-server-name-automatically-for-room-preview
branch
from
0028c93 to
ed4dc67
Compare
jmartinesp
deleted the
fix/include-server-name-automatically-for-room-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no server names are provided for the room summary request and the room's server name doesn't match the current user's server name, add the room alias/id server name as a fallback value. This seems to fix room preview through federation, when there is a server name in either the room id or alias.
Also, when getting a summary for a room list item, if it's an invite one, add the server name of the inviter's user id as another possible fallback.
Signed-off-by: