feat(sdk): (re)Enable HTTP/2 support #4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It became an optional default feature in reqwest 0.12, and we disable the default features, so I don't think it was meant to be disabled when the crate was upgraded. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
andybalaam
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Seems very sensible to me, but deferring to @poljar for the final word.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4566 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 285 285
Lines 32218 32218
=======================================
Hits 27515 27515
Misses 4703 4703 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It became an optional default feature in reqwest 0.12, and we disable the default features, so I don't think it was meant to be disabled when the crate was upgraded in #3362.