feat(appservice): Improve autojoin example #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannescpk
force-pushed
the
appservice/autojoin-example
branch
from
e4b01d0
to
719c5ad
Compare
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
=======================================
Coverage 72.63% 72.63%
=======================================
Files 107 107
Lines 15934 15934
=======================================
Hits 11574 11574
Misses 4360 4360 Continue to review full report at Codecov.
|
|
CI failure seems unrelated. |
|
A rebase should fix the CI, after that we can merge. |
johannescpk
force-pushed
the
appservice/autojoin-example
branch
from
719c5ad
to
4865fac
Compare
poljar
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The already registered user check could probably also happen inside
register_virtual_user- but not sure if there are scenarios where consumers might want to know that the error happened.Context: https://matrix.to/#/!iYnZafYUoXkeVPOSQh:matrix.org/$8QgFf_IBjMBGojAri_aZeGBLuC1rU-O0Ni7Fy3s3G1c?via=matrix.org&via=famedly.de&via=gnome.org
Part of #228