Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent clap upgrades beyond 3.2 #761

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Prevent clap upgrades beyond 3.2 #761

merged 1 commit into from
Jun 14, 2022

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jun 14, 2022

@jplatte jplatte requested a review from a team June 14, 2022 08:14
@ShadowJonathan
Copy link
Contributor

TLDR; they added confusing warnings stemming from derives, with no clear way to resolve them, and shipped 3.2 with that.

@jplatte jplatte merged commit dd4c329 into main Jun 14, 2022
@jplatte jplatte deleted the jplatte/clap branch June 14, 2022 09:02
@@ -6,7 +6,7 @@ publish = false

[dependencies]
atty = "0.2.14"
clap = "3.1.12"
clap = "~3.1.12"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants