refactor(appservice)!: Improve API and cleanup docs #837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
lib.rs
was slowly growing a bit too large and covering multiple contexts it was about time to refactor a bit. Also clarified the implicit behavior which special-cases thesender_localpart
user.sender_localpart
onAppService
constructionregister_event_handler
andregister_event_handler_context
, so the consumer has to be explicitget_cached_client
as it's already covered by the methodvirtual_user
create_session
into theVirtualUserBuilder
, as it's only used therevirtual_user_client*
tovirtual_user*
to make it more conciseNamespaceCache
private since there's no reason to expose itAppServiceRegistration
andVirtualUserBuilder
into their own files to make the code easier to navigatePart of #228