Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC 1267: Interactive key verification using short authentication strings #1267

Closed
uhoreg opened this issue May 28, 2018 · 8 comments
Closed

MSC 1267: Interactive key verification using short authentication strings #1267

uhoreg opened this issue May 28, 2018 · 8 comments
Assignees
@turt2live
Labels
disposition-merge e2e kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Comments

@uhoreg
Copy link
Member

uhoreg commented May 28, 2018

Define a more user-friendly method of verifying device keys.

Documentation: https://docs.google.com/document/d/1SXmyjyNqClJ5bTHtwvp8tT1Db4pjlGVxfPQNdlQILqU/edit#
@uhoreg uhoreg added proposal-wip proposal A matrix spec change proposal labels May 28, 2018
@ara4n ara4n mentioned this issue Sep 7, 2018
Closed
@uhoreg uhoreg mentioned this issue Sep 8, 2018
Merged
@dali99 dali99 mentioned this issue Oct 12, 2018
Open
26 tasks
@uhoreg uhoreg changed the title Interactive Key Verification MSC 1267: Interactive key verification using short authentication strings Jan 8, 2019
@uhoreg
Copy link
Member Author

uhoreg commented Mar 5, 2019

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Mar 5, 2019 •
edited by richvdh
Loading

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Mar 5, 2019
@uhoreg uhoreg added the e2e label Apr 1, 2019
@dbkr
Copy link
Member

dbkr commented May 24, 2019

Just a couple of minor things on the doc: open questions we should close and updates to the emoji that got implemented. other than that, lgtm.

@richvdh
Copy link
Member

richvdh commented May 24, 2019

I've not worked through the cryptographic aspects of this, but from the protocol POV I'm happy. Have written a couple of questions on the doc which I'd like to see answers to over the next few days.

Also there seem to be a bunch of resolved comment threads on the doc which it would be good to close if you are happy they are addressed.

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 24, 2019
@mscbot
Copy link
Collaborator

mscbot commented May 24, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@redsky17 redsky17 mentioned this issue May 27, 2019
Closed
@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 30, 2019
@mscbot
Copy link
Collaborator

mscbot commented May 30, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live self-assigned this May 31, 2019
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed proposal-in-review labels Jun 3, 2019
turt2live added a commit that referenced this issue Jun 4, 2019
@turt2live
Spec SAS verification and the common key verification framework
a3364ff 
Reference implementations:
* https://gitlab.matrix.org/matrix-org/olm/commit/94f664e7256215f33639dbbad6aaf87ada082a9f
* matrix-org/matrix-react-sdk#2461
* matrix-org/matrix-js-sdk#818
* matrix-org/matrix-react-sdk#2596
* matrix-org/matrix-js-sdk#837

Proposals:
* [MSC1717](#1717)
* [MSC1267](#1267)

No alterations to either proposal have been made intentionally here.
@turt2live turt2live mentioned this issue Jun 4, 2019
Merged
@turt2live
Copy link
Member

Spec PR: #2072

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Jun 4, 2019
@turt2live
Copy link
Member

merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 7, 2019
@turt2live turt2live added the kind:core MSC which is critical to the protocol's success label Apr 21, 2020
@uhoreg uhoreg mentioned this issue Mar 30, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
disposition-merge e2e kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dbkr @uhoreg @turt2live @anoadragon453 @richvdh @mscbot