Add status for unknown user's filter ID #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
richvdh
reviewed
Nov 6, 2017
api/client-server/filter.yaml
Outdated
| @@ -147,5 +147,7 @@ paths: | |||
| type: object | |||
| allOf: | |||
| - $ref: "definitions/sync_filter.yaml" | |||
| 400: | |||
There was a problem hiding this comment.
shouldn't this be a 404? (Even if synapse is returning 400 here)
There was a problem hiding this comment.
I don't know what should be the status code.This PR is only to document existing behavior so the community can benefit from it.
There was a problem hiding this comment.
Let me put it more strongly then. "I think this should be a 404 and synapse should be fixed".
There was a problem hiding this comment.
Set to 404 following your feedback.
|
👍 |
14 tasks
RiotTranslateBot
pushed a commit
to RiotTranslateBot/matrix-doc
that referenced
this pull request
Aug 22, 2023
* Attempt to define a valid event Resolves matrix-org#1044. Well, maybe. * Changelog * link to /rooms, thanks Travis Co-authored-by: Travis Ralston <travpc@gmail.com> Co-authored-by: Travis Ralston <travpc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a spec omission about the specific status code returned when an unknown user's filter ID is requested.
Signed-off-by: Max Dor @ Kamax.io (no email to avoid spam)