Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic spec for group IDs, mostly copied from User IDs as they share grammar #1289

Merged
merged 1 commit into from
Jul 24, 2018
Merged

basic spec for group IDs, mostly copied from User IDs as they share grammar #1289

merged 1 commit into from
Jul 24, 2018

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 11, 2018 •
edited by richvdh
Loading

Fixes #1029

there is no changelog for the appendices it looks like, correct me if I'm wrong

@t3chguy
Copy link
Member Author

t3chguy commented Jun 11, 2018

gendoc runs fine here, advise as to why proposals.py (unrelated) is failing

richvdh
richvdh reviewed Jul 24, 2018
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming it's correct. Please could you add an entry to the changelogs directory?

richvdh
richvdh approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait, we don't have a changelog for the appendices. LGTM then.

@t3chguy t3chguy merged commit 2790c1f into master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @richvdh