Explicitly declare that the kick/ban reason will be on the membership event #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
commented
Jul 3, 2018
| @@ -34,6 +34,10 @@ paths: | |||
| Kick a user from the room. | |||
|
|
|||
| The caller must have the required power level in order to perform this operation. | |||
|
|
|||
There was a problem hiding this comment.
The paragraph below was added to help describe what is going on. It is an almost direct copy/paste from the "Banning users" section.
erikjohnston
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798
This PR documents existing behaviour and does not attempt to improve or change the situation.
Reference: https://github.com/matrix-org/synapse/blob/53969e196004659c6a9f138f5d8abd86f4957d74/synapse/rest/client/v1/room.py#L639-L641