-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filtering API documentation #1570
Update filtering API documentation #1570
Conversation
EventFilter !== Filter Fixes matrix-org#1509
This is just maintenance.
Indentation, excess examples.
Note: This is badly named until matrix-org#1570 lands Fixes matrix-org#598
i think this almost fixes #1508, but it still needs CSS to actually make the tables & headings legible. That's an entirely separate problem though (although one i'd like to try to fix this week somehow!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I've updated the title of #1508 to be more generic in respect to fixing it spec-wide. I'd say it's unlikely to get done before Friday, however there is some light at the end of the r0 tunnel. I'll put on the r0 list under the cosmetic fixes (as that's what it is), although all the cosmetic stuff is under the heading "if we have time...". |
Rendered: see 'docs' status check
This PR may be best to review commit-by-commit.
Fix naming of the Filter schemas
EventFilter !== Filter
Fixes #1509
Update room_event_filter.yaml to use the OpenAPI allOf definition
Mark the filter_id in the response of POST /filter as required
Clean up examples in filter.yaml
Define the default for the contains_url filter param
Fixes #1553