Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC1693: Specify how to handle rejected events in new state res #1693

Merged
merged 24 commits into from
Dec 23, 2018

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Oct 8, 2018

It's possible for events in an an event's auth chain to be rejected due
to not having passed auth (based on the state at the time), so we need
to be explicit about how to handle that case.

Updates MSC #1442

Rendered full doc

It's possible for events in an an event's auth chain to be rejected due
to not having passed auth (based on the state at the time), so we need
to be explicit about how to handle that case.
@erikjohnston erikjohnston requested a review from a team October 8, 2018 13:28
@erikjohnston
Copy link
Member Author

(Note that you can ask github to show a rich diff, alas it doesn't appear to have a stable link though)

@erikjohnston erikjohnston removed the request for review from a team October 8, 2018 15:17
@erikjohnston
Copy link
Member Author

I also need to think a bit about how to deal with "reverse topological power ordering", in particular:

  1. x's sender has a greater power level than y (calculated by looking at
    their respective auth events), or if

@turt2live turt2live added proposal-wip proposal A matrix spec change proposal s2s Server-to-Server API (federation) labels Oct 9, 2018
@erikjohnston erikjohnston requested a review from a team October 9, 2018 09:38
@richvdh richvdh mentioned this pull request Oct 10, 2018
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about some things here.

In terms of process: I think we need to get some clarity on how this is supposed to work (hence #1694), but I don't think we should be changing existing proposal docs once they are accepted and merged into the spec.

proposals/1442-state-resolution.md Outdated Show resolved Hide resolved
proposals/1442-state-resolution.md Outdated Show resolved Hide resolved
proposals/1442-state-resolution.md Outdated Show resolved Hide resolved
@ara4n
Copy link
Member

ara4n commented Oct 30, 2018

MSC processwise we really should have closed this once it was merged into the spec, and started a new MSC to fix the rejections stuff. But in the interest of minimising bureaucracy let's just wrap it up here and then close this (and merge the result again into the spec).

@erikjohnston
Copy link
Member Author

MSC processwise we really should have closed this once it was merged into the spec, and started a new MSC to fix the rejections stuff. But in the interest of minimising bureaucracy let's just wrap it up here and then close this (and merge the result again into the spec).

TBH I thought it had been agreed that updating an existing proposal doc was fine in certain circumstances, like adding clarifications or whatever, so long as it is documented that it has been updated.

@erikjohnston erikjohnston requested a review from a team November 1, 2018 09:25
@mscbot mscbot removed the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Dec 18, 2018
@KitsuneRal
Copy link
Member

@mscbot resolve Fix typos

I didn't expect FCP to be broken by petty typo fixing request - sorry for the mess.

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Dec 18, 2018
@mscbot
Copy link
Collaborator

mscbot commented Dec 18, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@erikjohnston erikjohnston force-pushed the erikj/state_res_rejections branch from e906dd7 to 8fb2bd2 Compare December 18, 2018 09:47
@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Dec 23, 2018
@mscbot
Copy link
Collaborator

mscbot commented Dec 23, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

@anoadragon453 anoadragon453 merged commit f714aaa into master Dec 23, 2018
@anoadragon453 anoadragon453 added the spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec label Jan 3, 2019
@richvdh
Copy link
Member

richvdh commented Jan 3, 2019

I believe this is implemented in synapse, so it should be spec-pr-missing, not finished-final-comment-period

@anoadragon453
Copy link
Member

Good point, those old labels will confuse things. I do need to get the bot to switch to our custom labels still.

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Jan 7, 2019
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jan 24, 2019
@turt2live
Copy link
Member

Merged via #1773 🎉

@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal s2s Server-to-Server API (federation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants