-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC1693: Specify how to handle rejected events in new state res #1693
Conversation
It's possible for events in an an event's auth chain to be rejected due to not having passed auth (based on the state at the time), so we need to be explicit about how to handle that case.
(Note that you can ask github to show a rich diff, alas it doesn't appear to have a stable link though) |
I also need to think a bit about how to deal with "reverse topological power ordering", in particular:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about some things here.
In terms of process: I think we need to get some clarity on how this is supposed to work (hence #1694), but I don't think we should be changing existing proposal docs once they are accepted and merged into the spec.
MSC processwise we really should have closed this once it was merged into the spec, and started a new MSC to fix the rejections stuff. But in the interest of minimising bureaucracy let's just wrap it up here and then close this (and merge the result again into the spec). |
TBH I thought it had been agreed that updating an existing proposal doc was fine in certain circumstances, like adding clarifications or whatever, so long as it is documented that it has been updated. |
… that can happen?!
@mscbot resolve Fix typos I didn't expect FCP to be broken by petty typo fixing request - sorry for the mess. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
e906dd7
to
8fb2bd2
Compare
The final comment period, with a disposition to merge, as per the review above, is now complete. |
I believe this is implemented in synapse, so it should be spec-pr-missing, not finished-final-comment-period |
Good point, those old labels will confuse things. I do need to get the bot to switch to our custom labels still. |
Merged via #1773 🎉 |
It's possible for events in an an event's auth chain to be rejected due
to not having passed auth (based on the state at the time), so we need
to be explicit about how to handle that case.
Updates MSC #1442
Rendered full doc