MSC1943: Set default room as v3

[neilisfragile]

Rendered

[uhoreg]

(non-blocking comment) Given that v2 is probably not widely used publicly, and would have been created by people who hopefully should know what they're doing, I'd be tempted to mark it as unstable right away.

[neilisfragile]

good idea

[richvdh]

a few corrections

[richvdh]

the default is a recommendation; we can't change the behaviour of old servers.

[neilisfragile]

I don't see a contradiction here, whatever the default the server has, the description is accurate. I've made a change further down to clarify that the default is only a recommendation.

[turt2live]

technically speaking /createRoom allows for specifying a room version which is not of the default, making the statement here untrue. However, I don't think this is the thing we need to get stuck on.

[richvdh]

ok I think I misread this. All new rooms are inherently created by a server, so I just read it as "All new rooms are of the default version."

I think what you mean is "By default, new rooms created by a server are of the default version for that server", which is somewhat tautologous. I guess I'm just not sure this sentence adds clarity rather than confusion. Perhaps:

Homeservers support multiple room versions. Each server has a default version which is used when creating new rooms.

[turt2live]

While servers are ready, I would like to see how clients hold up to v3 before going forward with the proposal. Riot does a good enough job (in future releases, not in 1.1.0rc1) that I'm okay with marking it as safe, however there's potentially problems with Nheko-reborn, Quaternion, etc which make this concerning to land.

As mentioned elsewhere, landing MSC1884 with appropriate adoption from servers would also be sufficient.

Edit: also as mentioned elsewhere, client authors are encouraged to comment on this MSC

[richvdh]

lgtm

[richvdh]

ok I think I misread this. All new rooms are inherently created by a server, so I just read it as "All new rooms are of the default version."

I think what you mean is "By default, new rooms created by a server are of the default version for that server", which is somewhat tautologous. I guess I'm just not sure this sentence adds clarity rather than confusion. Perhaps:

Homeservers support multiple room versions. Each server has a default version which is used when creating new rooms.

[ara4n]

If #1884 merges, then we should probably be setting default room to v4 instead.

[richvdh]

unconvinced: it will take a while for v4 (whatever it ends up being) to roll out across the federation, whereas v3 has already been out for several weeks.

[neilisfragile]

I've changed my mind here fwiw. If we go to the trouble of implementing #1884 then I can't see sense in shipping v3 as default. Though agree with @richvdh comment that it pushes back the date that we can change default from v1.

dismissing review: Client authors haven't shown up in hoards to complain about this, so I am assuming it is probably fine

[turt2live]

I think it's safe to get this going, even though v4 and friends are on the horizon. In the interest of getting the federation to a more stable place, I propose we merge this now.

@mscbot fcp merge

[mscbot]

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

• @KitsuneRal
• @anoadragon453
• @ara4n
• @dbkr
• @erikjohnston
• @richvdh
• @turt2live
• @uhoreg

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[ara4n]

@mscbot fcp cancel

as per #2002 we’re skipping to v4.

[mscbot]

@ara4n proposal cancelled.

[ara4n]

shall we just mark this as obsolete and close?

[turt2live]

Considering we're fast-tracking #2002, yes. Closing as obsolete.