Spec v5 rooms: Key validity #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposals: * [MSC2076](#2076) * [MSC2077](#2077) Implementation references: * matrix-org/synapse@00bf99f * matrix-org/synapse#5354 * matrix-org/synapse#5321 No known differences from the proposals are included here - alterations are accidental.
This was referenced Jun 5, 2019
Merged
ara4n
reviewed
Jun 10, 2019
ara4n
reviewed
Jun 10, 2019
ara4n
reviewed
Jun 10, 2019
ara4n
reviewed
Jun 10, 2019
| When validating event signatures, servers MUST enforce the ``valid_until_ts`` property | ||
| from a key request is at least as large as the ``origin_server_ts`` for the event being | ||
| validated. Servers missing a copy of the signing key MUST try to obtain one via the | ||
| `GET /_matrix/key/v2/server <../server_server/r0.1.1.html#get-matrix-key-v2-server-keyid>`_ |
There was a problem hiding this comment.
should this be /latest rather than /r0.1.1?
There was a problem hiding this comment.
latest is only a thing on matrix.org's hosted copy, so for development it's actually easier to s/r0.1.0/r0.1.1 at release time.
|
looks plausible other than review |
|
@richvdh needs to review this one, though, i think |
also misc formatting fixes
|
I'm going to count two people as being uncertain as 1 being completely certain. We can always clarify this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot be merged until BOTH proposals have passed FCP. Asking for early review in preparation for that.
Proposals:
Implementation references:
Fixes #2075
No known differences from the proposals are included here - alterations are accidental.